Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join efforts? #32

Open
mpariente opened this issue Jan 25, 2021 · 4 comments
Open

Join efforts? #32

mpariente opened this issue Jan 25, 2021 · 4 comments

Comments

@mpariente
Copy link

Hi @tky823, nice repo !

We'd welcome most of this code in Asteroid if you'd like to contribute 😃 Would you?

Cheers,

@tky823
Copy link
Owner

tky823 commented Jan 26, 2021

Hi @mpariente, I'm interested in DNN-based source separation.
I would be happy to contribute to Asteroid. What is the first step?

@mpariente
Copy link
Author

Great!

What is the first step?

Well, there are architectures here that we don't have in Asteroid, it would be super cool to have them there.
For example, DANet and ADANet, or the Furca architectures.

Have you had a look at our source code and the organization?
There are some constraints for the code to be consistent between models (easier maintenance and lower barrier for users).
Anything would be welcome actually!

@tky823
Copy link
Owner

tky823 commented Jan 26, 2021

I have not read the constraints, so I will have a look.

I've confirmed that DANet separates the mixtures. But I have not checked the score (e.g. SDR improvement).
As for ADANet and the Furca, very little progress has been made in their implementation, sorry.

I use a free Google Colaboratory plan to make sure my implementation works, so it may take some time, but I'd like to join efforts.

@mpariente
Copy link
Author

There are also some Asteroid users that might be able to run your architectures on bigger hardware.

Feel free to join Asteroid's slack workspace to start discussing 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants