We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/tinylibs/tinybench/blob/v2.5.0/src/bench.ts#L11
https://github.com/tinylibs/tinybench/blob/v2.5.0/src/task.ts#L4
I suggest leaving only the import Task in the branch
import Task
After approval, I can create a PR (with backward compatibility, of course, as far as possible)
The text was updated successfully, but these errors were encountered:
Can you elaborate on what you are suggesting? But yeah, circular dependencies should be avoided
Sorry, something went wrong.
in Task to receive an interface with the necessary parameters and implement this interface in Bench
Task
Bench
and make deprecated https://github.com/tinylibs/tinybench/blob/v2.5.1/src/task.ts#L19
and next step, (maybe in v3.0.0) remove this column
Task is uselessly using a reference to Bench instead of using from it only the bits needed.
No branches or pull requests
https://github.com/tinylibs/tinybench/blob/v2.5.0/src/bench.ts#L11
https://github.com/tinylibs/tinybench/blob/v2.5.0/src/task.ts#L4
I suggest leaving only the
import Task
in the branchAfter approval, I can create a PR (with backward compatibility, of course, as far as possible)
The text was updated successfully, but these errors were encountered: