Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian basis set handling: aiida ORM types and electron edits should be decoupled #36

Closed
blokhin opened this issue Apr 10, 2020 · 2 comments

Comments

@blokhin
Copy link
Member

blokhin commented Apr 10, 2020

There is an architectural issue, as aiida_crystal_dft.data.basis.CrystalBasisData has double responsibilities:

  • accommodating Aiida ORM
  • editing electron initial distribution and dumping the content

Ideally, they should be decoupled from each other as it allows more granular usage.

cf. #34

@blokhin blokhin changed the title Gaussian basis set handling: aiida ORM types and electron edits must be decoupled Gaussian basis set handling: aiida ORM types and electron edits should be decoupled Apr 10, 2020
@ansobolev
Copy link
Member

The problem here lies in the aiida architecture: when the workflow is submitted, all the objects are serialized to DB, and then get deserialized in their turn, so that they can call the code that belongs to them, hence, it's not easy to call another function that doesn't belong to serialized object, as it's quite difficult to tell from outside, what data was serialized. Moreover, setting oxidation state involves heavy use of the inner dict and alters the innards of the basis object, so it belongs to the object. It can be noted, that the function is rather top-level, all the calculations belong elsewhere.

@blokhin
Copy link
Member Author

blokhin commented Jul 20, 2020

Let me re-phrase. Is it possible to use that code bypassing AiiDA? e.g. to change the oxidation states in a structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants