Reorganise plot rendering #6665
Merged
+372
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
approved these changes
Nov 18, 2025
Member
thomasp85
left a comment
thomasp85
left a comment
There was a problem hiding this comment.
I'll trust the tests to ensure you haven't messed up during copy-paste :-)
Collaborator
Author
|
That's what tests are for! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a pet peeve of mine: the build method(s) don't read very nicely.
First off,
ggplot_build()andggplot_gtable()are in the same file, which is messy because they are both user-facing functions, they do things independently and are also documented separately.Secondly, I understand why
ggplot_build()is hard to read: it is complicated.However,
ggplot_gtable()has a lot of gtable operation complexity, which can be easily hidden away in some choice helper functions. It becomes a lot simpler to understand whatggplot_gtable()is doing if the steps are separate functions.