Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeomBar should use rename_size = TRUE #4923

Closed
yutannihilation opened this issue Jul 27, 2022 · 2 comments · Fixed by #4939
Closed

GeomBar should use rename_size = TRUE #4923

yutannihilation opened this issue Jul 27, 2022 · 2 comments · Fixed by #4939

Comments

@yutannihilation
Copy link
Member

During comparing GeomBar and GeomCol on #4921, I found GeomBar doesn't have rename_size = TRUE specified.

I think we can just add rename_size = TRUE to GeomBar and replace GeomCol with GeomCol <- ggproto("GeomCol", GeomBar) as a first step towards #3798
@thomasp85
Copy link
Member

good catch - do you want to take this?

@yutannihilation
Copy link
Member Author

Yes, I'll make a PR after #4921 gets merged.

@yutannihilation yutannihilation mentioned this issue Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rename_size = TRUE to GeomBar yutannihilation/ggplot2
2 participants
@thomasp85 @yutannihilation