From 1abc2425e438209a27a4e710af1ed75b3db3cfd1 Mon Sep 17 00:00:00 2001 From: JJ-Cro Date: Mon, 10 Feb 2025 14:03:08 +0100 Subject: [PATCH 1/3] feat(v3.10.32): add params for GetDeliveryRecord, fixed e2e tests --- .github/workflows/e2etest.yml | 23 +++++++++++------------ package-lock.json | 4 ++-- package.json | 2 +- src/types/request/v5-asset.ts | 2 ++ 4 files changed, 16 insertions(+), 15 deletions(-) diff --git a/.github/workflows/e2etest.yml b/.github/workflows/e2etest.yml index 38ef71c2..9518c157 100644 --- a/.github/workflows/e2etest.yml +++ b/.github/workflows/e2etest.yml @@ -1,16 +1,12 @@ -name: 'Build & Test' +name: E2ETests # Changed to match KuCoin naming -on: [push] - -# on: -# # pull_request: -# # branches: -# # - "master" -# push: -# branches: +on: + push: + pull_request: # Added pull_request trigger + workflow_dispatch: # Added manual trigger option jobs: - build: + E2ETests: # Changed job ID to match KuCoin name: 'Build & Test' runs-on: ubuntu-latest @@ -30,8 +26,11 @@ jobs: - name: Build run: npm run build - - name: Test - run: npm run test + - name: Test Public API Calls # Split test command into public and private + run: npm run test -- public.test.ts + + - name: Test Private API Calls # Added separate step for private API tests + run: npm run test -- private.test.ts env: API_KEY_COM: ${{ secrets.API_KEY_COM }} API_SECRET_COM: ${{ secrets.API_SECRET_COM }} diff --git a/package-lock.json b/package-lock.json index 3f9ed248..d68a2ade 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "bybit-api", - "version": "3.10.31", + "version": "3.10.32", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "bybit-api", - "version": "3.10.31", + "version": "3.10.32", "license": "MIT", "dependencies": { "axios": "^1.6.6", diff --git a/package.json b/package.json index 35bdc940..f3fc2d9e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "bybit-api", - "version": "3.10.31", + "version": "3.10.32", "description": "Complete & robust Node.js SDK for Bybit's REST APIs and WebSockets, with TypeScript & strong end to end tests.", "main": "lib/index.js", "types": "lib/index.d.ts", diff --git a/src/types/request/v5-asset.ts b/src/types/request/v5-asset.ts index 3de59cdd..7e22199a 100644 --- a/src/types/request/v5-asset.ts +++ b/src/types/request/v5-asset.ts @@ -10,6 +10,8 @@ export interface GetCoinExchangeRecordParamsV5 { export interface GetDeliveryRecordParamsV5 { category: CategoryV5; symbol?: string; + startTime?: number; + endTime?: number; expDate?: string; limit?: number; cursor?: string; From 0a4104dd9158596251fb991e6ed3162079ebbd43 Mon Sep 17 00:00:00 2001 From: JJ-Cro Date: Mon, 10 Feb 2025 14:23:02 +0100 Subject: [PATCH 2/3] fix(): updated test file names --- .github/workflows/e2etest.yml | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2etest.yml b/.github/workflows/e2etest.yml index 9518c157..f95902d9 100644 --- a/.github/workflows/e2etest.yml +++ b/.github/workflows/e2etest.yml @@ -26,11 +26,18 @@ jobs: - name: Build run: npm run build - - name: Test Public API Calls # Split test command into public and private - run: npm run test -- public.test.ts + - name: Test Public Read API Calls + run: npm run test -- public.read.test.ts + + - name: Test Private Read API Calls + run: npm run test -- private.read.test.ts + + - name: Test Private Write API Calls + run: npm run test -- private.write.test.ts + + - name: Test Public WS + run: npm run test -- public.ws.test.ts - - name: Test Private API Calls # Added separate step for private API tests - run: npm run test -- private.test.ts env: API_KEY_COM: ${{ secrets.API_KEY_COM }} API_SECRET_COM: ${{ secrets.API_SECRET_COM }} From 5b981d05e31c6d3e8e5ee8909541fef20294f336 Mon Sep 17 00:00:00 2001 From: JJ-Cro Date: Mon, 10 Feb 2025 14:53:40 +0100 Subject: [PATCH 3/3] chore(): removed unnecesary comments --- .github/workflows/e2etest.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2etest.yml b/.github/workflows/e2etest.yml index f95902d9..47d3d62d 100644 --- a/.github/workflows/e2etest.yml +++ b/.github/workflows/e2etest.yml @@ -1,12 +1,12 @@ -name: E2ETests # Changed to match KuCoin naming +name: E2ETests on: push: - pull_request: # Added pull_request trigger - workflow_dispatch: # Added manual trigger option + pull_request: + workflow_dispatch: jobs: - E2ETests: # Changed job ID to match KuCoin + E2ETests: name: 'Build & Test' runs-on: ubuntu-latest