Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The implementation of update_expert_mapping does not work for optimizer states of experts #3

Open
qyhfrank opened this issue May 1, 2024 · 1 comment
Open

The implementation of update_expert_mapping does not work for optimizer states of experts #3

qyhfrank opened this issue May 1, 2024 · 1 comment

Comments

@qyhfrank
Copy link

qyhfrank commented May 1, 2024

Thank you for your work! I've recently been reading the source code of SmartMoE and noticed that there is no implementation for transferring the optimizer state of experts in the update_expert_mapping function in layer.py. Could this potentially cause issues with gradient updates?
@zms1999
Copy link
Collaborator

zms1999 commented May 1, 2024

I have noticed this problem. I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qyhfrank @zms1999