System Proxy checkbox not working

[amymor]

Operating system

Windows

System version

11

Installation type

zip

Version

1.1.3-1.1.5

Description

The System Proxy checkbox doesn't work. It only applies when the profile is started and only revert proxy to the default(off) when you stop the profile, which is confusing.
Also, if you don't have it checked, start/stop doesn't change anything, for example, check that checkbox, then start a profile, then unchecking it doesn't do anything. Now after this, the "Stop" doesn't revert the Windows proxy settings to the default(off) until you check it again and start/stop the profile.

Reproduction

Run the app as Administrator, then check or uncheck System Proxy, then go to Windows Settings > Network & Internet > Proxy, no change will be made, while in the old Nekoray, checking this option will change the proxy settings.

Old Nekoray:

Logs

[amymor]

I tried #1529, this build is better but it still only works when you have an active (started) profile, when there is no active profile, the checkbox does nothing.
I think the problem is in the start/stop function which also includes applying proxy settings, while proxy settings should only be changed with the checkbox alone.

[dreik]

as I can see the fix is already implemented but not released yet.
as a temporary solution you can downgrade to 1.1.4 or use unreleased version from: https://github.com/throneproj/Throne/actions/runs/27104415146
I've already tried both ways on my system and both looks good to me.

[Chara-Freedom]

@Mahdi-zarei please release a new version now for this to be fixed it is a rather critical bug, one of my users suffered from it (I PRed Throne in my TG channel once again because of AWG 2.0 support and one of the readers panicked when system proxy broke, its annoying).

[amymor]

unreleased version from: https://github.com/throneproj/Throne/actions/runs/27104415146

Same as #1529 (only works when you have a started profile).

[Mahdi-zarei]

There is currently a bug with system proxy, but its intended behavior is now same as Tun mode, it only sets system proxy when a profile is running (but as i said, it should behave exactly like Tun, and the fact that it does not turn off properly is a regression)

[Mahdi-zarei]

There are a couple more fixes for other issues in https://github.com/throneproj/Throne/actions/runs/27163580193
if I get confirmation that they all work, I will release 1.1.6 as soon as possible.

[amymor]

But in the old Nekoray as well as v2rayN, the System Proxy checkbox applies regardless of whether a profile is running or not. Many users are used to this, so this new behavior confuses them. Also, when you stop one profile and start another, the proxy is turned off and your IP is visible for a short time, while in the old behavior, the checkbox acted like a kill switch.

[Mahdi-zarei]

so this new behavior confuses them

Why would it confuse them? It is not normal for someone to use the system proxy button to cut off their internet. I am open to discussing whether or not system proxy should only be enabled when a profile is running, but your reasoning is just: "it was like that, so it should remain that way", and I need better argument as to why we should or should not keep the system proxy behavior that way.
By the way using the system proxy as a kill switch is not really a valid point, system proxy is bypassed by many apps, so if you want to hide your IP you need better solutions.

[Chara-Freedom]

Yes the new behavior is a very valid idea because if you for some reason closed the app but didn't turn off the system proxy it was stuck like this until you start the app again, it was reasonable but not too convenient compared to tun

The only problem is that it broke after the change, the idea itself is cool I support it.

[Chara-Freedom]

Previously any person could start the profile in system proxy, then stop it, then be confused why internet died; but unfortunately now there is even more confusion because it doesn't do the right thing.

[Mahdi-zarei]

Try 1.1.6
the main issue regarding system proxy not switching states properly is fixed.
please open another issue if you feel the current behavior needs to be changed, and we can discuss it there.

[Chara-Freedom]

I personally favor system proxy because in some of my testing it behaved better in advanced server-side tunneling and I can use it along side my own app Tor Portable without a conflict unlike full tun.

[Chara-Freedom]

the main issue regarding system proxy not switching states properly is fixed.

Tested, 100% fixed!

As I said, the new fixed behavior is nice and unique addition. I always proudly say that your app is the best, those standards are very high, please keep it! Wish you the best

[amymor]

so this new behavior confuses them

Why would it confuse them? It is not normal for someone to use the system proxy button to cut off their internet. I am open to discussing whether or not system proxy should only be enabled when a profile is running, but your reasoning is just: "it was like that, so it should remain that way", and I need better argument as to why we should or should not keep the system proxy behavior that way. By the way using the system proxy as a kill switch is not really a valid point, system proxy is bypassed by many apps, so if you want to hide your IP you need better solutions.

The checkbox is there for a reason, the logic behind the checkbox is to do something. Also, many programs use system proxy and all browsers have an option for it, so it's nice to have a simple kill switch. If you don't use it, it doesn't mean that no one will need it, I think there should at least be an option in the settings to change that behavior like Nekoray/v2rayN.

if you for some reason closed the app but didn't turn off the system proxy it was stuck like this until you start the app again

This problem can be easily solved by automatically clearing proxy settings on exit.

[Chara-Freedom]

it doesn't mean that no one will need it

You should speak for yourself and not hypothetically; were YOU using it like this consciously for something?