Road to Throne #525
Replies: 80 comments 95 replies
-
|
Currently I am preparing the new icon/tray images. Then I need to rename some internal code stuff, preferably removing the word |
Beta Was this translation helpful? Give feedback.
-
|
I have created "1.0" milestone https://github.com/throneproj/nekoray/milestone/1. |
Beta Was this translation helpful? Give feedback.
-
|
I will add legacy windows support to the main repository next week. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei I refactored the code of core. Convert core server to a shared library. |
Beta Was this translation helpful? Give feedback.
-
|
Export symbols: |
Beta Was this translation helpful? Give feedback.
-
|
Useage: Here is a modified version of |
Beta Was this translation helpful? Give feedback.
-
|
Windows build nekoray.zip. |
Beta Was this translation helpful? Give feedback.
-
|
I once thought about having the core as a lib, like Libbox that SFA uses, but there are several issues that make it hard. First thing is that we lose the ability to hard restart the core, as it no longer is a process you could simply kill or restart. Another is that on Linux you cannot set the system proxy when running as the root user, but you need root access for Tun mode. Third is actually there are lots of system Calls in the sing-box and I am kinda worried that not all of them will work properly when compiled to c code. So I guess it is best to keep the core a separate process to ensure things will remain safe and also have more control over it as a separate process. |
Beta Was this translation helpful? Give feedback.
-
|
There also seems to be a weird bug with the simple-protobuf library, #534, in this issue, from the second call onwards, the |
Beta Was this translation helpful? Give feedback.
-
|
I fixed the issue with spb. There is also another thing that makes it not worth making the core a clib, and that is its crashes will cause the whole app to crash, we can of course add a recover to the main function but it really isn't a solution. So my final thought is that even though it is amazing to have a single binary to distribute, the amount of problems and complexities is simply too much and it is not a good idea to do it. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei Thank you so much for your detailed explanation. I will stop further research on it. |
Beta Was this translation helpful? Give feedback.
-
|
Regarding simple protobuf, there are issues with default values as having fields set as required makes api calls cumbersome as we cant leave them empty, and having them set as optional will require a |
Beta Was this translation helpful? Give feedback.
-
|
Setting a default value for a required field(like fd421d0) works or not? |
Beta Was this translation helpful? Give feedback.
-
|
It does work in the context of the value you read from it, but the problem is if you don't provide that field, the rpc will fail. Setting it as optional causes the code to break and we need to make significant changes. |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/throneproj/nekoray/tree/refs/heads/optional_field |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei Some users report high memory usage after we migrating to new outbound-based proxy entity.
|
Beta Was this translation helpful? Give feedback.
-
|
Seems to be an issue. Once i finish the work on crash dumps i will work on it, will need to get a heap profile to see if we need to optimize or if we are having some memory leak. |
Beta Was this translation helpful? Give feedback.
-
|
It seems the issue is that since our new data model has all the fields, it simply uses more ram. I think we should move to sqlite for our data storage, this way we do not need to load everything into ram. We also need to refactor the proxy list to use custom qt models so that the app won't lag on tab switches. This can take quite a long time since it is a fundamental change on how we manage every part of the app... |
Beta Was this translation helpful? Give feedback.
-
|
It seems the current protorpc library does not have proper connection multiplexing and uses lots of connections. Do you think we should use another library (possibly falling back to gRPC)? |
Beta Was this translation helpful? Give feedback.
-
|
Confirmed! I will start working on it in the next few days. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei done https://github.com/throneproj/Throne/tree/grpc. |
Beta Was this translation helpful? Give feedback.
-
|
Nice! Let's ship it in the next beta. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei I found a UI Enhanced Edition of original nekoray. What do you think of the UI style? |
Beta Was this translation helpful? Give feedback.
-
|
I like minimalistic UI, so i did not really like the looks of it. If we could apply some modernization, adaptive icons etc, it would be good, but overall, i personally am not a fan of that type of UI. |
Beta Was this translation helpful? Give feedback.
-
|
Okay! Understood. If you like this type of UI, I think we can invite him to join the Throne development. |
Beta Was this translation helpful? Give feedback.
-
|
I think it will be best if we focus on adding useful features for now. Tastes differ, but i think our main ui is good enough. |
Beta Was this translation helpful? Give feedback.
-
|
Are you planning to add a load balancer like in Exclave (Android)? |
Beta Was this translation helpful? Give feedback.
-
|
No we do not. Please discuss these in issues. |
Beta Was this translation helpful? Give feedback.
-
|
Multi-column filter feature has been merged. It is disabled by default. Users can enable/disable filter by pressing filter.mp4 |
Beta Was this translation helpful? Give feedback.
-
|
It works great! Let me add warp support and then we can release 1.1.0 . |
Beta Was this translation helpful? Give feedback.
-
|
I guess we should release the stable version now, do you know of any bugs we have to fix before doing it? |
Beta Was this translation helpful? Give feedback.
-
|
We can't always refresh the column width, it lags the app when the group is too large. We need to improve our detection on when it needs it. Also drag and drop of files seem to be broken due to Qt upgrade, I need to fix it too. There are some issues with wireguard too that i suspect it might be due to golang upgrade, should check that out as well. |
Beta Was this translation helpful? Give feedback.
-
|
Understood! |
Beta Was this translation helpful? Give feedback.
-
|
Ok seems like wireguard's problem was with golang 1.26 and now it works. The issue with drag and drop is due to windows security issues and only happens when Throne is admin. |
Beta Was this translation helpful? Give feedback.
-
https://github.com/throneproj/Throne/actions/runs/22691006719 |
Beta Was this translation helpful? Give feedback.
-
|
It works well. I fixed a minor issue 0207005. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei I added support for Juicity, TrustTunnel, ShadowTLS protocols to the |
Beta Was this translation helpful? Give feedback.
-
|
I feel it is best to keep it for 1.1.1, lets just fix up our issues and release the stable version first. But it's great to have them! We may also be able to add support for some other protocols via extra core (built in support based on our current extra core implementation) |
Beta Was this translation helpful? Give feedback.
-
|
Okay! It will be merged after releasing v1.1.0. |
Beta Was this translation helpful? Give feedback.
-
|
Support for Juicity, TrustTunnel, ShadowTLS protocols has been merged. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei The upstream sing-box repository creates |
Beta Was this translation helpful? Give feedback.
-
|
Yes we should also rename our branches to match the upstream for easier upgrades. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei With so many improvements and fixes in place, I think we're ready for a new version. |
Beta Was this translation helpful? Give feedback.
-
|
A few small things are left, I will add them and we will release. |
Beta Was this translation helpful? Give feedback.
-
|
I have added support for chaining Xray configs (sing->xray->sing at most, cannot transition between cores more than that) |
Beta Was this translation helpful? Give feedback.
-
|
xray->sing and xray with warp work perfactly. |
Beta Was this translation helpful? Give feedback.
-
|
Can you give me a public Xray subscription please (some of its configs should work so that i can test with them)? |
Beta Was this translation helpful? Give feedback.
-
|
It looks weird. if i chain the config you sent me into itself, it fails, but from what i can see the config that is generated looks correct. The case where Xray chains into sing-box also fails as you said, which makes me to believe maybe there is an issue with Xray chaining... |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/throneproj/Throne/actions/runs/24900911984 fixes it |
Beta Was this translation helpful? Give feedback.
-
|
It works! |
Beta Was this translation helpful? Give feedback.
-
|
I made some changes to secure the access between core and gui given that we have suid which is dangerous. Please give it a bit of testing, since we migrated from tcp to unix socket/named pipes. |
Beta Was this translation helpful? Give feedback.
-
|
After further testing, the issue of the program randomly exiting is present in https://github.com/throneproj/Throne/actions/runs/25877806195. Reproduce on windows:
|
Beta Was this translation helpful? Give feedback.
-
|
Fixed in https://github.com/throneproj/Throne/actions/runs/25908059958 |
Beta Was this translation helpful? Give feedback.
-
|
Crashing randomly on macOS 10.15.7 |
Beta Was this translation helpful? Give feedback.
-
|
Seems like a race condition. |
Beta Was this translation helpful? Give feedback.
-
|
Fantastic! Tested it out and it’s stable now. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei please review #1446 and #1447 when you have time 🙂 |
Beta Was this translation helpful? Give feedback.
-
|
Are there any issues you think we should work upon before release? I have tested the new version myself and it seems to be stable so far. |
Beta Was this translation helpful? Give feedback.
-
|
The new version is stable, and I haven't found any functional issues. |
Beta Was this translation helpful? Give feedback.
-
|
@Mahdi-zarei 29d9420 broke the |
Beta Was this translation helpful? Give feedback.
-
|
I was trying to prepare things for releasing throne in package managers, but did not find the time to keep at it. Feel free to revert that commit. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Leave your thoughts about Throne here.
Beta Was this translation helpful? Give feedback.
All reactions