Skip to content

Commit ecb54e3

Browse files
Add comments
Highlighting some things that need to be addressed based on the generated app.
1 parent c688feb commit ecb54e3

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

templates/Gemfile.erb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ gem "sprockets", "< 4"
2323
gem "title"
2424
gem "tzinfo-data", platforms: [:mingw, :x64_mingw, :mswin, :jruby]
2525
<%# TODO: Remove this, and consider passing an option to the `rails new` command for esbuild %>
26+
<%# TODO: Maybe this is how we conditionally handle dependencies that need a bundler %>
27+
<%# unless options[:javascript] %>
2628
<%# gem "webpacker" %>
2729
# Rails 7
2830
gem "sprockets-rails"

templates/_javascript.html.erb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
<%# TODO: Replace this with javascript_tag %>
2+
<%# TODO: We might want to do conditionally do this though, incase the app is using webpackeh %>
13
<%= javascript_pack_tag :application %>
24

35
<%= yield :javascript %>

templates/application.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
@charset "utf-8";
22

3+
// TODO: We need to explore using cssbundling-rails with postcss to load this
34
@import "normalize.css/normalize";
45

56
@import "bourbon";

0 commit comments

Comments
 (0)