fix: corrected ldap_connect()

Author: thorsten

phpmyfaq/config/ldap.php.original

@@ -1,5 +1,5 @@
 <?php
-// Main LDAP server
+// Main LDAP server, format the server as "ldap://127.0.0.1"
 $PMF_LDAP['ldap_server'] = '';
 $PMF_LDAP['ldap_port'] = 389;
 $PMF_LDAP['ldap_user'] = '';

phpmyfaq/src/phpMyFAQ/Ldap.php

@@ -30,26 +30,26 @@ class Ldap
     /**
      * Error.
      *
-     * @var string
+     * @var string|null
      */
-    public $error = null;
+    public ?string $error = null;
 
     /**
      * LDAP error number.
      *
-     * @var int
+     * @var int|null
      */
-    public $errno = null;
+    public ?int $errno = null;
 
     /**
      * @var array
      */
-    private $ldapConfig;
+    private array $ldapConfig;
 
     /**
      * @var Configuration
      */
-    private $config;
+    private Configuration $config;
 
     /**
      * An LDAP link identifier, returned by ldap_connect()
@@ -61,9 +61,9 @@ class Ldap
     /**
      * The LDAP base.
      *
-     * @var string
+     * @var string|null
      */
-    private $base = null;
+    private ?string $base = null;
 
     /**
      * Constructor.
@@ -99,7 +99,7 @@ public function connect(
         }
 
         $this->base = $ldapBase;
-        $this->ds = ldap_connect($ldapServer, $ldapPort);
+        $this->ds = ldap_connect($ldapServer . ':' . $ldapPort);
 
         if (!$this->ds) {
             $this->error = sprintf(