fix: added missing fix on object, closes #2095

Author: thorsten

phpmyfaq/admin/assets/src/content/category.js

@@ -17,8 +17,6 @@ import Sortable from 'sortablejs';
 import { addElement } from '../../../../assets/src/utils';
 
 export const handleCategories = () => {
-  console.log('handleCategories');
-
   const listGroupItems = document.querySelectorAll('.list-group-item');
   const sortableCategories = document.querySelector('.list-group.list-group-root');
 
@@ -32,61 +30,63 @@ export const handleCategories = () => {
     });
   });
 
-  const sortable = Sortable.create(sortableCategories, {
-    animation: 150,
-    dataIdAttr: 'data-id',
-    filter: '.pmf-category-not-sortable',
-    group: 'pmf-category-order',
-    store: {
-      /**
-       * Get the order of elements. Called once during initialization.
-       * @param   {Sortable}  sortable
-       * @returns {Array}
-       */
-      get: (sortable) => {
-        const order = localStorage.getItem(sortable.options.group.name);
-        return order ? order.split('|') : [];
-      },
+  if (sortableCategories) {
+    const sortable = Sortable.create(sortableCategories, {
+      animation: 150,
+      dataIdAttr: 'data-id',
+      filter: '.pmf-category-not-sortable',
+      group: 'pmf-category-order',
+      store: {
+        /**
+         * Get the order of elements. Called once during initialization.
+         * @param   {Sortable}  sortable
+         * @returns {Array}
+         */
+        get: (sortable) => {
+          const order = localStorage.getItem(sortable.options.group.name);
+          return order ? order.split('|') : [];
+        },
 
-      /**
-       * Save the order of elements. Called onEnd (when the item is dropped).
-       * @param {Sortable}  sortable
-       */
-      set: (sortable) => {
-        const order = sortable.toArray();
-        const csrf = document.querySelector('input[name=csrf]').value;
-        localStorage.setItem(sortable.options.group.name, order.join('|'));
+        /**
+         * Save the order of elements. Called onEnd (when the item is dropped).
+         * @param {Sortable}  sortable
+         */
+        set: (sortable) => {
+          const order = sortable.toArray();
+          const csrf = document.querySelector('input[name=csrf]').value;
+          localStorage.setItem(sortable.options.group.name, order.join('|'));
 
-        fetch('index.php?action=ajax&ajax=categories&ajaxaction=update-order', {
-          method: 'POST',
-          headers: {
-            Accept: 'application/json, text/plain, */*',
-            'Content-Type': 'application/json',
-          },
-          body: JSON.stringify({
-            csrf: csrf,
-            order: order,
-          }),
-        })
-          .then(async (response) => {
-            if (response.status === 200) {
-              return response.json();
-            }
-            throw new Error('Network response was not ok.');
-          })
-          .then((response) => {
-            sortableCategories.insertAdjacentElement(
-              'beforebegin',
-              addElement('div', { classList: 'alert alert-success', innerText: response.success })
-            );
+          fetch('index.php?action=ajax&ajax=categories&ajaxaction=update-order', {
+            method: 'POST',
+            headers: {
+              Accept: 'application/json, text/plain, */*',
+              'Content-Type': 'application/json',
+            },
+            body: JSON.stringify({
+              csrf: csrf,
+              order: order,
+            }),
           })
-          .catch((error) => {
-            sortableCategories.insertAdjacentElement(
-              'beforebegin',
-              addElement('div', { classList: 'alert alert-danger', innerText: error })
-            );
-          });
+            .then(async (response) => {
+              if (response.status === 200) {
+                return response.json();
+              }
+              throw new Error('Network response was not ok.');
+            })
+            .then((response) => {
+              sortableCategories.insertAdjacentElement(
+                'beforebegin',
+                addElement('div', { classList: 'alert alert-success', innerText: response.success })
+              );
+            })
+            .catch((error) => {
+              sortableCategories.insertAdjacentElement(
+                'beforebegin',
+                addElement('div', { classList: 'alert alert-danger', innerText: error })
+              );
+            });
+        },
       },
-    },
-  });
+    });
+  }
 };

yarn.lock

@@ -2907,14 +2907,7 @@ jest-worker@^27.4.1:
     merge-stream "^2.0.0"
     supports-color "^8.0.0"
 
-jquery-ui@^1.13.1:
-  version "1.13.1"
-  resolved "https://registry.yarnpkg.com/jquery-ui/-/jquery-ui-1.13.1.tgz#d0b7a42e73a04c31bb5706adf86f6f8942f64eaa"
-  integrity sha512-2VlU59N5P4HaumDK1Z3XEVjSvegFbEOQRgpHUBaB2Ak98Axl3hFhJ6RFcNQNuk9SfL6WxIbuLst8dW/U56NSiA==
-  dependencies:
-    jquery ">=1.8.0 <4.0.0"
-
-"jquery@>=1.7.1 <4.0.0", "jquery@>=1.8.0 <4.0.0", jquery@^3.4.1:
+"jquery@>=1.7.1 <4.0.0", jquery@^3.4.1:
   version "3.6.0"
   resolved "https://registry.yarnpkg.com/jquery/-/jquery-3.6.0.tgz#c72a09f15c1bdce142f49dbf1170bdf8adac2470"
   integrity sha512-JVzAR/AjBvVt2BmYhxRCSYysDsPcssdmTFnzyLEts9qNwmjmu4JTAMYubEfwVOSwpQ1I1sKKFcxhZCI2buerfw==