Adding Mode chain definitions

[sshmaxime]

The Mode chain definition is missing. It's pretty weird considering you guys have modeTestnet.

[linear]

TOOL-2980 Adding `Mode` chain definitions

[gregfromstl]

Hey @sshmaxime, I'm not sure why we would have Mode's testnet and not Mode but we'd generally like to minimize the number of predefined chain definitions. You can get Mode's chain definition with defineChain(34443) (which is arguably easier than the predefined chains).

[sshmaxime]

Hello @gregfromstl , you marked this as completed but I'm not seeing it in the latest version of Thirdweb. I tried to check the branches to see if I wasn't up to date but I checked on main and the type definition for Mode doesn't appear - I can still see Mode Testnet tho.

Did I miss something ?

Would you please mind adding it ? It's more practical for us to import the chain directly than having them in our own repository. Thanks 🙏

[gregfromstl]

Hey @sshmaxime I may have misunderstood. Is there a reason you can't use defineChain?

[sshmaxime]

The reason is that I like to have a clean code with the the least customized stuff on our side. We are already implementing few of your chains using thirdweb/chains, I'm just hoping to see the addition of the Mode chain .. it's easier for us and probably for some of your other users too 🙏

[gregfromstl]

We like to have clean code too 🙂

Adding named imports for every chain (2,500+) would dramatically increase our repo size and upkeep, as chains have their exceptions/edge cases. That's why we prefer to minimize the number of chains that have named imports (and ideally we would have none). That said, because you seem like a great guy and we already have mode testnet I've opened a PR to add it as a predefined chain: #5982

[sshmaxime]

Thank you @gregfromstl 🙏