Filter out null-ish values from ERC721 and ERC1155 getNFTs() arrays (#8311)

Author: jnsdls

.changeset/good-regions-dig.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+filter out null-ish values from `ERC721.getNFTs()` and `ERC1155.getNFTs()` arrays

packages/thirdweb/src/extensions/erc1155/read/getNFTs.ts

@@ -52,12 +52,18 @@ export async function getNFTs(
   const { useIndexer = true } = options;
   if (useIndexer) {
     try {
-      return await getNFTsFromInsight(options);
+      return await getNFTsFromInsight(options).then((nfts) =>
+        nfts.filter((nft) => nft?.id !== undefined && nft?.id !== null),
+      );
     } catch {
-      return await getNFTsFromRPC(options);
+      return await getNFTsFromRPC(options).then((nfts) =>
+        nfts.filter((nft) => nft?.id !== undefined && nft?.id !== null),
+      );
     }
   }
-  return await getNFTsFromRPC(options);
+  return await getNFTsFromRPC(options).then((nfts) =>
+    nfts.filter((nft) => nft?.id !== undefined && nft?.id !== null),
+  );
 }
 
 async function getNFTsFromInsight(

packages/thirdweb/src/extensions/erc721/read/getNFTs.ts

@@ -71,12 +71,18 @@ export async function getNFTs(
   const { useIndexer = true } = options;
   if (useIndexer) {
     try {
-      return await getNFTsFromInsight(options);
+      return await getNFTsFromInsight(options).then((nfts) =>
+        nfts.filter((nft) => nft?.id !== undefined && nft?.id !== null),
+      );
     } catch {
-      return await getNFTsFromRPC(options);
+      return await getNFTsFromRPC(options).then((nfts) =>
+        nfts.filter((nft) => nft?.id !== undefined && nft?.id !== null),
+      );
     }
   }
-  return await getNFTsFromRPC(options);
+  return await getNFTsFromRPC(options).then((nfts) =>
+    nfts.filter((nft) => nft?.id !== undefined && nft?.id !== null),
+  );
 }
 
 /**