-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expo EAS server configuration for iOS does not include Java #11
Comments
I don't know any particulars about any third party services, or whether they include java or not. I don't even know what EAS is, so I really cannot offer any help on this. |
Looks like @wodin added the EAS Build notes in the Readme. @wodin Have you been able to build for iOS on EAS? |
Hi @peterbee I just saw your question here now. As I mentioned on the Expo forums you could try to install Java in a pre-build hook, but it might be best to just build the ClojureScript code before running @thheller, you're probably not terribly interested, but just in case: EAS is Expo Application Services, which includes a build service (EAS Build) for Expo apps and other React Native apps. So basically you run |
Seems like there should be a supported image that can handle all the IOS stuff and also has Java? |
This app should work as-is for Android, but given that the iOS build workers don't seem to have Java installed, I think I should update the documentation (and probably remove the The most straightforward approach to building this app using Expo's EAS Build service is to build the ClojureScript code before running The There are a couple of ways around this:
I'm leaning towards just committing the @thheller do you have any opinion on the above?
Yes, maybe you're right. Maybe I can get an opinion on that from the Expo team |
I'd very strongly recommend to never commit build output to git. That is just terrible. However, if thats the only way to get it to build go for it. I have never and will never use any of this, so do what gets the job done. ;) |
My impression is that the Expo team seems understandably unwilling to bulk up every macOS builder with a Java installation that the vast majority of users won't need. Although they do have different build types that you can choose from, they are only for different versions of the OS, Xcode, etc. But fortunately, Homebrew is available on the build workers, and installing I gave the following a try and it worked fine: build-cljs.sh #!/bin/bash
set -e
if [[ "$EAS_BUILD_PLATFORM" == "ios" ]]; then
HOMEBREW_NO_AUTO_UPDATE=1 brew install homebrew/cask-versions/temurin11
fi
exec npx shadow-cljs release app package.json {
"scripts": {
"eas-build-post-install": "./build-cljs.sh"
}
} In the test app, I did not actually have a Shadow CLJS project, though. No |
Might still be good to open a support ticket. They already seem to provide a couple different images, should be easy to add one that also has a JVM installed. |
I agree it shouldn't be that hard for them to add another image, but they don't have any similar variations at the moment. It's currently just variations in OS versions and Xcode/node/etc. versions. Adding a new macOS image with Java would mean they would have to maintain that going forward (and possibly different images for different OS, Xcode, etc. versions), so I would understand if they don't want to do that. Anyway, I'm OK with the status quo. If someone else wants to persuade the Expo team to create a macOS + Java image, then they can create the ticket :) |
My iOS builds are failing on Expo EAS because Java is not found. The EAS Server Configuration documentation also does not mention Java on iOS build machines.
The Android build worked correctly.
Have iOS builds worked with
shadow-cljs release app
on EAS in the past?The text was updated successfully, but these errors were encountered: