Fixed problem where operator=(PolymorphicWrapper& other) would actually

therocode · therocode · commit c251e3428b56 · 2018-09-08T10:25:31.000+02:00
not copy
diff --git a/include/thero/polymorphicwrapper.hpp b/include/thero/polymorphicwrapper.hpp
@@ -49,7 +49,7 @@ class PolymorphicWrapper
 
     PolymorphicWrapper& operator=(PolymorphicWrapper& other)
     {
-        return static_cast<const PolymorphicWrapper&>(other);
+        return *this = static_cast<const PolymorphicWrapper&>(other);
     }
 
     PolymorphicWrapper& operator=(PolymorphicWrapper&& other)

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ class PolymorphicWrapper`
`49`	`49`
`50`	`50`	`PolymorphicWrapper& operator=(PolymorphicWrapper& other)`
`51`	`51`	`{`
`52`		`- return static_cast<const PolymorphicWrapper&>(other);`
	`52`	`+ return *this = static_cast<const PolymorphicWrapper&>(other);`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`PolymorphicWrapper& operator=(PolymorphicWrapper&& other)`