Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In app search to filter contacts list #18

Open
morajabi opened this issue Jul 23, 2018 · 0 comments
Open

In app search to filter contacts list #18

morajabi opened this issue Jul 23, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers Priority: Low Status: Accepted

Comments

@morajabi
Copy link
Member

morajabi commented Jul 23, 2018 •
edited
Loading

cleanshot 2018-07-23 at 12 26 09

It doesn't need to contact API to filter since normally you wouldn't have more than 100 entries (that's very rare too!) so we are good to just apply a .filter on the entries array(s) and add an input to the top of entries.

I think we can hide the search input for users with less than 5 entries.

Please comment if you have suggestions or you want to tackle this!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Priority: Low Status: Accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@morajabi