Skip to content

Optional methods in GatewayInterface cause deprecations #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garak opened this issue Mar 17, 2025 · 0 comments
Open

Optional methods in GatewayInterface cause deprecations #712

garak opened this issue Mar 17, 2025 · 0 comments

Comments

@garak
Copy link

garak commented Mar 17, 2025

Using the @method annotation in an interface is probably not the best solution.

All the unimplemented methods raise a deprecation:

1x: Class "Omnipay\PayPal\ProGateway" should implement method "Omnipay\Common\GatewayInterface::acceptNotification(array $options = array()): \Omnipay\Common\Message\NotificationInterface": (Optional method) Receive and handle an instant payment notification (IPN).
    1x in DeprecationErrorHandler::shutdown from Symfony\Bridge\PhpUnit

  1x: Class "Omnipay\PayPal\ProGateway" should implement method "Omnipay\Common\GatewayInterface::completeAuthorize(array $options = array()): \Omnipay\Common\Message\RequestInterface": (Optional method) Handle return from off-site gateways after authorization.
    1x in DeprecationErrorHandler::shutdown from Symfony\Bridge\PhpUnit

  1x: Class "Omnipay\PayPal\ProGateway" should implement method "Omnipay\Common\GatewayInterface::completePurchase(array $options = array()): \Omnipay\Common\Message\RequestInterface": (Optional method) Handle return from off-site gateways after purchase.
    1x in DeprecationErrorHandler::shutdown from Symfony\Bridge\PhpUnit

  1x: Class "Omnipay\PayPal\ProGateway" should implement method "Omnipay\Common\GatewayInterface::void(array $options = array()): \Omnipay\Common\Message\RequestInterface": (Optional method) Generally can only be called up to 24 hours after submitting a transaction.
    1x in DeprecationErrorHandler::shutdown from Symfony\Bridge\PhpUnit

  1x: Class "Omnipay\PayPal\ProGateway" should implement method "Omnipay\Common\GatewayInterface::createCard(array $options = array()): \Omnipay\Common\Message\RequestInterface": (Optional method) The returned response object includes a cardReference, which can be used for future transactions.
    1x in DeprecationErrorHandler::shutdown from Symfony\Bridge\PhpUnit

  1x: Class "Omnipay\PayPal\ProGateway" should implement method "Omnipay\Common\GatewayInterface::updateCard(array $options = array()): \Omnipay\Common\Message\RequestInterface": (Optional method) Update a stored card.
    1x in DeprecationErrorHandler::shutdown from Symfony\Bridge\PhpUnit

  1x: Class "Omnipay\PayPal\ProGateway" should implement method "Omnipay\Common\GatewayInterface::deleteCard(array $options = array()): \Omnipay\Common\Message\RequestInterface": (Optional method) Delete a stored card.
    1x in DeprecationErrorHandler::shutdown from Symfony\Bridge\PhpUnit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant