Skip to content

Handle Case When Extended FV Header Does Not Exist #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle Case When Extended FV Header Does Not Exist #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82e280e
Handle Case When Extended FV Header Does Not Exist
nate-desimone Mar 8, 2025
768e5f6
Fix Extended FV Header Decoding Errors
nate-desimone Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion uefi_firmware/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def __init__(self, data, search=True):
data = data[self.offset:]
self.data = data

header = data[:100]
header = data[:200]
for tester in checker.TESTERS:
if tester().match(header):
self.data_type = tester().name
Expand Down
17 changes: 9 additions & 8 deletions uefi_firmware/uefi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,14 +1377,15 @@ def __init__(self, data, name="0"):
print_error("Error invalid FV header data (%s)." % str(e))
return

try:
exthdr = self._data[self.exthdroff:self.exthdroff + self._EXT_HEADER_SIZE]
self.fvname, self.exthdrsize = struct.unpack("<16sI", exthdr)
assert self.exthdrsize == self._EXT_HEADER_SIZE
except Exception as e:
dlog(self, name, "Exception in __init__: %s" % (str(e)))
print_error("Error invalid FV header data (%s)." % str(e))
# not fatal
if self.exthdroff != 0:
try:
exthdr = self._data[self.exthdroff:self.exthdroff + self._EXT_HEADER_SIZE]
self.fvname, self.exthdrsize = struct.unpack("<16sI", exthdr)
assert self.exthdrsize == self._EXT_HEADER_SIZE
except Exception as e:
dlog(self, name, "Exception in __init__: %s" % (str(e)))
print_error("Error invalid FV header data (%s)." % str(e))
# not fatal

self.valid_header = True
pass
Expand Down
Loading