Handle Case When Extended FV Header Does Not Exist #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the UEFI Platform Initialization (PI) Specification 1.8A, Volume 3, Section 3.2.1.1, the ExtHeaderOffset field can be zero. In which case, the Extended FV Header does not exist. If ExtHeaderOffset is zero, do not attempt to parse the Extended FV Header. Spec Reference: https://uefi.org/specs/PI/1.8A/V3_Code_Definitions.html#efi-firmware-volume-header Signed-off-by: Nate DeSimone <[email protected]>
When decoding headers, fetch 200 bytes instead of 100 bytes. This prevents "Error invalid FV header data" errors when parsing firmware volumes that contain an extended header. Often, the extended header on such firmware volumes extends past the first 100 bytes. Signed-off-by: Nate DeSimone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the UEFI Platform Initialization (PI) Specification 1.8A, Volume 3, Section 3.2.1.1, the ExtHeaderOffset field can be zero. In which case,
the Extended FV Header does not exist.
If ExtHeaderOffset is zero, do not attempt to parse the Extended FV Header.
Spec Reference: https://uefi.org/specs/PI/1.8A/V3_Code_Definitions.html#efi-firmware-volume-header