-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Labels
enhancementProposed new feature. There are no guarantees a suggested enhancement will be included in Quire.Proposed new feature. There are no guarantees a suggested enhancement will be included in Quire.figuresIssue related to figures (incl. image, video, audio, table)Issue related to figures (incl. image, video, audio, table)status:selected for developmentIssue has been triaged and will be fixedIssue has been triaged and will be fixed
Description
Before proceeding, check to make sure there isn’t an existing issue for this idea or a similar one.
- I have searched the existing issues and determined this is a new proposal.
Proposed change
This is an enhancement for our sanity and not repeating logic. There should be a way to prepend all relative values for figure.src with the image directory when the project builds, so that we don't have to repeat this logic in multiple places every time a figure src is referenced in a shortcode (currently in: figure image shortcode, figure video shortcode, get-image-service helper)
Possible solutions:
1.) Create a computed figures property in eleventyComputed
2.) Add a method to add optional transforms to data before figures is added to the global data in _plugins/globalData
Potential Impact
Sanity
Supporting Information
This suggestion was originally posted to Jira on 15/Aug/22 by Hannah as DEV-12941.
As discussed, @cbutcosk will be looking at it as part of his work on issue #1171.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementProposed new feature. There are no guarantees a suggested enhancement will be included in Quire.Proposed new feature. There are no guarantees a suggested enhancement will be included in Quire.figuresIssue related to figures (incl. image, video, audio, table)Issue related to figures (incl. image, video, audio, table)status:selected for developmentIssue has been triaged and will be fixedIssue has been triaged and will be fixed