Add option to allow unauthenticated access to metrics, and for generic additions to auth #904
+57
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraenki
force-pushed
the
unauth_metrics
branch
3 times, most recently
from
8f10bf0 to
b7641d8
Compare
ekohl
reviewed
Feb 13, 2024
Contributor
|
I also would like to see this move forward, I need the |
|
Yes, please lets get this merged, it is a simple and backwards-compatible change that will really help with flexibility. |
Contributor
…c additions to auth
fraenki
force-pushed
the
unauth_metrics
branch
from
a63bd47 to
52f5717
Compare
Contributor
Author
|
Rebased with |
Contributor
|
A test is failing, but maybe it's not related? Can we re-run the test if it's flaky? Also, would it make sense to add tests to cover this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a resubmission of #849, rebased against current master branch to resolve conflicts. Fixes #850. Credits to @sshipway.
This minor change allows generic control of the auth.conf file, and permitting unauthenticated retrieval of metrics (as is required by our monitoring system)