downcase puppet_flavor fact

Author: bastelfreak

lib/facter/puppet_flavor.rb

@@ -4,7 +4,7 @@
   confine { Facter::Core::Execution.which('puppet') }
   setcode do
     output = Facter::Core::Execution.execute('puppet --help')
-    output.split[-2] if output
+    output.split[-2].downcase if output
   end
 end
 

manifests/params.pp

@@ -264,7 +264,7 @@
   $puppet_major = regsubst($facts['puppetversion'], '^(\d+)\..*$', '\1')
 
   # Add support for OpenVox. Default to puppet if nothing is installed yet
-  $puppet_flavor       = pick($facts['puppet_flavor'], 'puppet').downcase()
+  $puppet_flavor       = pick($facts['puppet_flavor'], 'puppet')
   $puppetserver_flavor = regsubst("${puppet_flavor}server", 'openvox', 'openvox-')
 
   $server_package = if ($facts['os']['family'] =~ /(FreeBSD|DragonFly)/) {

spec/unit/puppet/facter/puppet_flavor_spec.rb

@@ -92,15 +92,15 @@ module            Creates, installs and searches for modules on the Puppet Forge
           puppet_string
         end
       end
-      it { expect(Facter.fact(:puppet_flavor).value).to eq('Puppet') }
+      it { expect(Facter.fact(:puppet_flavor).value).to eq('puppet') }
     end
     context 'with OpenVox' do
       before do
         allow(Facter::Core::Execution).to receive(:execute).with('puppet --help') do
           openvox_string
         end
       end
-      it { expect(Facter.fact(:puppet_flavor).value).to eq('OpenVox') }
+      it { expect(Facter.fact(:puppet_flavor).value).to eq('openvox') }
     end
   end
 end