ReDoS advisory for useragent #936
codedsultan
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi! 👋
I’d like to replace the unmaintained useragent dependency with ua-parser-js. Motivation: long-standing ReDoS concerns around regex backtracking in useragent.
I’ll keep behaviour identical for analytics:
Implementation outline:
Optional follow-up PR (behind env flag): skip obvious bots using isbot with SKIP_BOTS=false by default.
If this direction looks good, I’ll submit PR A (swap lib; no behaviour change) and then PR B (optional bot filtering).
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions