Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Improve Exception Handling #541

Open
Casper-Guo opened this issue Mar 4, 2024 · 0 comments
Open

[ENH] Improve Exception Handling #541

Casper-Guo opened this issue Mar 4, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@Casper-Guo
Copy link
Contributor

Proposed new feature or change:

Discussed in #536

To be worked on:

A well-thought-out plan on how to improve the current situation, which (additional) exceptions might be necessary, which base classes to use, ... would already be a good step in the right direction.

Ideas:

all exceptions can be imported from a single submodule, either directly from fastf1 or from something like fastf1.exceptions
all exceptions are documented
all exceptions use reasonable base classes: that might be Exception for some, a more specific default exception like ValueError for others or another more general custom exception
the exceptions are logically structured and extensible (similar to how the two Ergast exceptions inherit from a common base class)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants