Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect Qatar Sprint results due to not applied penalties #463

Open
mdsakalu opened this issue Oct 10, 2023 · 3 comments
Open

[BUG] Incorrect Qatar Sprint results due to not applied penalties #463

mdsakalu opened this issue Oct 10, 2023 · 3 comments
Labels
blocked:ergast bug Something isn't working external The problem is not caused by FastF1
Milestone

Comments

@mdsakalu
Copy link
Contributor

Describe the issue:

Sprint results from 2023 Qatar are wrong when loading from F1 live timing API due to penalties applied after the finish. Not sure if there are any data sources to allow fastf1 to apply penalties outside of the official FIA documents or ergast.

Reproduce the code example:

qatar = fastf1.get_event(2023, 17)
sprint = qatar.get_sprint()
sprint.load()
print(sprint.results)

Error message:

No response

@theOehrly
Copy link
Owner

No, there are no other data sources for this data. And given that Ergast does not support the Sprint, it's currently impossible for FastF1 to provide the correct results.

@harningle
Copy link
Contributor

I think the only good source for penalties are only available from FIA decision documents. But if you are interested in the post-penalty correct finishing order, formula1.com is pretty good and easy to use/scrape (https://www.formula1.com/en/results.html/2023/races/1221/qatar/sprint-results.html).

@theOehrly Maybe worth adding sprint race support to #445?

@theOehrly
Copy link
Owner

@theOehrly Maybe worth adding sprint race support to #445?

It's not mentioned there, but I'm intending to support all session types, yes.

@theOehrly theOehrly added needs more information Further information is requested and removed needs more information Further information is requested labels Oct 19, 2023
@theOehrly theOehrly changed the title [BUG] Is there a data source for post race penalties? [BUG] Incorrect Qatar Sprint results due to not applied penalties Nov 24, 2023
@theOehrly theOehrly added bug Something isn't working external The problem is not caused by FastF1 labels Nov 24, 2023
@theOehrly theOehrly added this to the v3.2.0 milestone Nov 24, 2023
@theOehrly theOehrly removed this from the v3.2.0 milestone Jan 5, 2024
@theOehrly theOehrly added this to the future milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked:ergast bug Something isn't working external The problem is not caused by FastF1
Projects
None yet
Development

No branches or pull requests

3 participants