Restore founders to volunteer page #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for the-collab-lab ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mxmason
changed the title
mxmason
commented
Jun 13, 2023
| volunteer: Collabie; | ||
| } | ||
|
|
||
| export function Volunteer({ volunteer }: VolunteerProps) { |
There was a problem hiding this comment.
🔍 I had to rename this component because some changes in Astro mean that the component name Volunteer conflicts with some global name declaration on the volunteer.astro page.
Comment on lines
+20
to
+26
| where: { | ||
| AND: [ | ||
| { NOT: { roles_every: { name: "Participant" } } } | ||
| { roles_some: {} } | ||
| { visible: true } | ||
| ] | ||
| } |
There was a problem hiding this comment.
🔍 The roles_some query here makes sure we only get collabies who have at least one defined role
| orderBy: firstName_ASC | ||
| ) { | ||
| ...collabieData | ||
| roles(where: { name_not: "Participant" }) { | ||
| roles(where: { name_not: "Participant" }, orderBy: name_ASC) { |
There was a problem hiding this comment.
🔍 Adding orderBy means we no longer have to order the roles during build
segdeha
approved these changes
Jun 13, 2023
mxmason
force-pushed
the
feat/restore-founders-to-site
branch
from
bc1533d to
c8639a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Andrew and Stacie back to the volunteers page by placing them in their own section, above the other volunteers. There's also a handful of little maintenance changes in the code.
On a desktop-size viewport, Andrew and Stacie's cards take up the full width of the row and are larger than the others because there's no third card in the row. I also chose to hide their roles, since they have so many and it looks messy, and "founder" is their most important role anyway.
Relevant issue
Closes #65