Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the "Get Ready" questions #61

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Add back the "Get Ready" questions #61

merged 4 commits into from
Sep 20, 2023

Conversation

mentalcaries
Copy link
Contributor

For this PR I:

  • created a new section with the "Get Ready" questions, since I didn't want to detract from the info in "How to apply"
  • used an ordered list (and styled accordingly) to match the numbered list on the previous website

The design is simple at this point. I'm on the fence as to if an image should be added to match the existing sections due to how much text there is.

Closes #54

@netlify
Copy link

netlify bot commented Apr 27, 2023 •
edited
Loading

✅ Deploy Preview for the-collab-lab ready!

Name Link
🔨 Latest commit d60e6b1
🔍 Latest deploy log https://app.netlify.com/sites/the-collab-lab/deploys/6496478f784b550008bd5f50
😎 Deploy Preview https://deploy-preview-61--the-collab-lab.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@segdeha
Copy link
Member

segdeha commented Apr 27, 2023

This is great, thanks so much for grabbing the issues, @mentalcaries!

@mxmason, would it be possible here to have this page render the list of regions based on those we're running rather than be statically coded? Could you provide guidance for how to achieve that?

mxmason
mxmason requested changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@mxmason mxmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @mentalcaries! It looks like you have to resolve a minor merge conflict, which is my fault for not reviewing this earlier.

Did you mean to uncomment the stats graphics on the "developers" page? I don't think those are ready to be back on the site yet. In any case, once you get this branch up to date with main, I have some ideas that could address Andrew's question about automatically rendering the right list of cohort regions on the "participare" page.

@mentalcaries
Copy link
Contributor Author

Thanks for this, @mentalcaries! It looks like you have to resolve a minor merge conflict, which is my fault for not reviewing this earlier.

Did you mean to uncomment the stats graphics on the "developers" page? I don't think those are ready to be back on the site yet. In any case, once you get this branch up to date with main, I have some ideas that could address Andrew's question about automatically rendering the right list of cohort regions on the "participare" page.

Good catch. Not sure why that section was uncommented. I might have been messing around with it to see what it was supposed to look like

@mxmason mxmason force-pushed the dj-application-form-questions branch from 21202b1 to d60e6b1 Compare June 24, 2023 01:31
@mentalcaries mentalcaries requested a review from mxmason September 2, 2023 14:25
@mentalcaries mentalcaries merged commit 0b27798 into main Sep 20, 2023
@mentalcaries mentalcaries deleted the dj-application-form-questions branch September 20, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmason mxmason mxmason approved these changes

@segdeha segdeha Awaiting requested review from segdeha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add back the application form questions
3 participants
@mentalcaries @segdeha @mxmason