fix: use inclusive language, tidy up footer #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for the-collab-lab ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
segdeha
approved these changes
Dec 22, 2022
src/components/Footer.astro
Outdated
| @@ -34,7 +34,7 @@ import { donationOptions } from '~data'; | |||
| { | |||
| donationOptions.length > 0 && ( | |||
| <Fragment> | |||
| <p> | |||
| <p style="margin-block-start: 1em;"> | |||
| We also accdept direct donations. Please consider supporting The | |||
| @@ -34,7 +34,7 @@ import { donationOptions } from '~data'; | |||
| { | |||
| donationOptions.length > 0 && ( | |||
| <Fragment> | |||
| <p> | |||
| <p style="margin-block-start: 1em;"> | |||
There was a problem hiding this comment.
Is there a reason we're using style attributes here and not classes?
There was a problem hiding this comment.
Yes: laziness. I've done this in a few small places and I want to come back and tidy up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15 – inclusive language
Fixes #16 – makes dev.to icon black
Fixes #17 – adds a link to our Mastodon account
Fixes #18 – adds vertical spacing before our "made with" credits
Also applies a few other minor spacing and layout fixes.