Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define new storage interface for physical plan? #157

Open
yeya24 opened this issue Jan 22, 2023 · 1 comment
Open

Define new storage interface for physical plan? #157

yeya24 opened this issue Jan 22, 2023 · 1 comment

Comments

@yeya24
Copy link
Contributor

yeya24 commented Jan 22, 2023

Right now the query engine implements the Prometheus query engine interface, which simply uses storage.Queryable as the storage interface.

The interface is quite limited now and the main API is Select to fetch data. It is hard to extend it for now and it is really related to the original promql engine, may not be that easy to extend in the future.

I am wondering if we should define new storage APIs for easier to pushdown or support any kind of physical plan in the future.
We can have some example implementation of the storage layer like using Frostdb.

@yeya24 yeya24 changed the title Define new storage interface for Define new storage interface for physical plan? Jan 22, 2023
@fpetkovski
Copy link
Collaborator

Querying other sources is an awesome idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants