Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$use-bounce issue #28

Open
Psychokrameur opened this issue Sep 22, 2016 · 1 comment
Open

$use-bounce issue #28

Psychokrameur opened this issue Sep 22, 2016 · 1 comment

Comments

@Psychokrameur
Copy link

Hello,

You are using $use-bounce variable for multiple purpose :

  • Activate all bounces effects
  • Attention seekers bounce effect

It seems that cause some trouble when want to use only the attention seekers.

Mabye it should be good to separate the variables
with $use-bounce and $use-bounces

Thanks in advance

@tgdev
Copy link
Owner

tgdev commented May 22, 2017

Hey @Psychokrameur ,

Thanks for the info. If you want you could branch off this repo, test out your solution above and if you think it's better then submit a PR for me to test and review. I' be happy to take a look :-)

Also re: the naming... maybe you could have $use-bounces and $use-seekers?

Cheers,
Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants