You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
Talking to @gioragutt regarding HTML collection and writing things down:
add a per-step hook (like screenshots/console-logs) that calls Page.captureSnapshot as mhtml and save it (don't use fast-mhtml yet). Make sure to add it to the config file and make sure it's off by default.
Open a PR.
On top of it - add fast-mhtml and add a step (in the viewer) that parses the mhtml using it to display the output of Page.captureSnapshot.
Takeaways:
Probably better to use Page.captureSnapshot and not DOMSnapshot given the standard format and the lack of info on parsing the output of DOMSnapshot.
Probably better to save the MHTML as a separate file like screenshots rather than inline it in the results file.
The text was updated successfully, but these errors were encountered:
Impl related question - CDPSession, can I acquire it early (as early as attach) and keep reference to it in the hook? Or should I get it every time I invoke the hook (probably not)?
In the util.ts code you showed me, I didn't see you closing the session, and I don't get the feeling from CDPSession['attach'] that you have to call to free up resources or whatever.
Talking to @gioragutt regarding HTML collection and writing things down:
Page.captureSnapshot
as mhtml and save it (don't use fast-mhtml yet). Make sure to add it to the config file and make sure it's off by default.fast-mhtml
and add a step (in the viewer) that parses the mhtml using it to display the output ofPage.captureSnapshot
.Takeaways:
Page.captureSnapshot
and notDOMSnapshot
given the standard format and the lack of info on parsing the output of DOMSnapshot.The text was updated successfully, but these errors were encountered: