-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links to https://svg.test-summary.com not working #58
Comments
Hey @ethomson, did you forget to prolong the registration of |
Maybe a stupid question, but why is the svg not embedded as a svg tag instead of pulling the image from a obscure website? |
@LjungErik I think that GH Markdown doesn't allow that. |
No but I must have broken something! I'll take a look. |
Thanks, folks, sorry I missed the ping initially, my notifications are a bit of a mess right now. 😅 I had broken DNS, and I've repaired it. It may take a little bit to propagate through caches. Thanks again for the ping! |
Thank you for fixing this! 💯 |
@LjungErik that SVG isn't static, in contains dynamically filled out data. |
Right; I'm running compute to generate those svgs. 😀 |
But also, I think that you can't embed SVGs inside GitHub-flavored Markdown? I admit that I haven't tried it in a few years, though, so maybe the state of the art has changed. |
I think it'd work if one of these things was true: either a static SVG (GH Pages would handle it) or the ability to embed SVG into Markdown. Referencing standalone SVG files got fixed back in 2022: https://github.blog/changelog/2022-01-21-allow-to-upload-svg-files-to-markdown/. But I don't think the MD sanitizer changed since. |
In build summary used icons are not showing up because the links points to non working website.
https://svg.test-summary.com/dashboard.svg?p=409&f=3&s=23
The text was updated successfully, but these errors were encountered: