Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to https://svg.test-summary.com not working #58

Open
severikupari1 opened this issue Feb 13, 2025 · 11 comments
Open

Links to https://svg.test-summary.com not working #58

severikupari1 opened this issue Feb 13, 2025 · 11 comments

Comments

@severikupari1
Copy link

In build summary used icons are not showing up because the links points to non working website.

Image

Image

https://svg.test-summary.com/dashboard.svg?p=409&f=3&s=23

@webknjaz
Copy link
Contributor

Hey @ethomson, did you forget to prolong the registration of test-summary.com?

@LjungErik
Copy link

Maybe a stupid question, but why is the svg not embedded as a svg tag instead of pulling the image from a obscure website?

@webknjaz
Copy link
Contributor

@LjungErik I think that GH Markdown doesn't allow that.

@ethomson
Copy link
Member

No but I must have broken something! I'll take a look.

@ethomson
Copy link
Member

Thanks, folks, sorry I missed the ping initially, my notifications are a bit of a mess right now. 😅

I had broken DNS, and I've repaired it. It may take a little bit to propagate through caches. Thanks again for the ping!

@severikupari1
Copy link
Author

Thank you for fixing this! 💯

@LjungErik
Copy link

@webknjaz @ethomson Can't we just host the SVGs on Github directly instead of having a external dependency on a website

@webknjaz
Copy link
Contributor

@LjungErik that SVG isn't static, in contains dynamically filled out data.

@ethomson
Copy link
Member

Right; I'm running compute to generate those svgs. 😀

@ethomson
Copy link
Member

But also, I think that you can't embed SVGs inside GitHub-flavored Markdown? I admit that I haven't tried it in a few years, though, so maybe the state of the art has changed.

@webknjaz
Copy link
Contributor

I think it'd work if one of these things was true: either a static SVG (GH Pages would handle it) or the ability to embed SVG into Markdown. Referencing standalone SVG files got fixed back in 2022: https://github.blog/changelog/2022-01-21-allow-to-upload-svg-files-to-markdown/. But I don't think the MD sanitizer changed since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants