Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascii art renderer #924

Open
alixander opened this issue Feb 27, 2023 · 14 comments · May be fixed by #2353
Open

ascii art renderer #924

alixander opened this issue Feb 27, 2023 · 14 comments · May be fixed by #2353

Comments

@alixander
Copy link
Collaborator

our code is set up well to just plug in an ascii art renderer. i suspect still will be quite hard, though we can treat everything as rectangles to start to make it easier.

@cyborg-ts cyborg-ts added this to D2 Feb 27, 2023
@alixander
Copy link
Collaborator Author

https://github.com/ironcamel/Graph-Easy

@i-am-the-slime
Copy link

Any hope for this one?

@alixander
Copy link
Collaborator Author

Unfortunately there's no motivating factor right now.

Copy link

algora-pbc bot commented Feb 13, 2025

💎 $200 bounty • Terrastruct

Steps to solve:

  1. Start working: Comment /attempt #924 with your implementation plan
  2. Submit work: Create a pull request including /claim #924 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to terrastruct/d2!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @AkashJana18 Feb 14, 2025, 6:15:41 AM WIP
🟢 @DrSensor #2353

@AkashJana18
Copy link

AkashJana18 commented Feb 14, 2025

/attempt #924
I would like to work on this issue.
Hey @alixander can you shed some more light how to proceed further?

@DrSensor DrSensor linked a pull request Feb 14, 2025 that will close this issue
Copy link

algora-pbc bot commented Feb 14, 2025

💡 @DrSensor submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@alixander
Copy link
Collaborator Author

@AkashJana18 since there's a PR open, I'll let him proceed first and ping you if it doesn't work out

@alixander
Copy link
Collaborator Author

More context: #2353 (review)

@AkashJana18
Copy link

Hey @DrSensor, would you like to collaborate on this issue, or should I go ahead and start working on it? Or are you planning to handle it solo?

@alixander
Copy link
Collaborator Author

I'll give 72 hours to respond to comments each time. I'll keep it moving to ensure people have a fair shot @AkashJana18

@DrSensor
Copy link

@AkashJana18 i came up with other solution using grid based method so i want to handle it solo. i will mention you if i need help.

@bo-ku-ra
Copy link
Contributor

interesting if it is interconvertible.
https://ivanceras.github.io/svgbob-editor/

@alixander
Copy link
Collaborator Author

Well we already have SVG renderers so converting ASCII to SVG with another tool doesn't seem useful

@bo-ku-ra
Copy link
Contributor

umm, talk about SVG is short sighted...

that is great ascii art.
i believe that d2's ability to output compatibly is to produce beautiful ascii art output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants