feat: exposed the input management_endpoint_type_for_bucket for bucket DAs and defaulted the value to direct (#938)

Author: Aditya-ranjan-16

ibm_catalog.json

@@ -421,7 +421,6 @@
             },
             {
               "key": "management_endpoint_type_for_bucket",
-              "hidden": true,
               "options": [
                 {
                   "displayname": "direct",
@@ -759,6 +758,19 @@
             {
               "key": "bucket_hard_quota"
             },
+            {
+              "key": "management_endpoint_type_for_bucket",
+              "options": [
+                {
+                  "displayname": "direct",
+                  "value": "direct"
+                },
+                {
+                  "displayname": "private",
+                  "value": "private"
+                }
+              ]
+            },
             {
               "key": "monitoring_crn"
             },
@@ -1147,7 +1159,6 @@
             },
             {
               "key": "management_endpoint_type_for_bucket",
-              "hidden": true,
               "options": [
                 {
                   "displayname": "direct",
@@ -1544,6 +1555,19 @@
             {
               "key": "bucket_hard_quota"
             },
+            {
+              "key": "management_endpoint_type_for_bucket",
+              "options": [
+                {
+                  "displayname": "direct",
+                  "value": "direct"
+                },
+                {
+                  "displayname": "private",
+                  "value": "private"
+                }
+              ]
+            },
             {
               "key": "monitoring_crn"
             },

solutions/cross-regional-bucket/fully-configurable/variables.tf

@@ -126,7 +126,7 @@ variable "bucket_name" {
 variable "management_endpoint_type_for_bucket" {
   description = "The type of endpoint for the IBM terraform provider to manage the bucket. Possible values: `public`, `private`, `direct`."
   type        = string
-  default     = "private"
+  default     = "direct"
   validation {
     condition     = contains(["public", "private", "direct"], var.management_endpoint_type_for_bucket)
     error_message = "The value of management_endpoint_type_for_bucket must be one of: `public`, `private`, `direct`."

solutions/cross-regional-bucket/security-enforced/main.tf

@@ -14,7 +14,7 @@ module "cross_regional_bucket" {
   existing_cos_instance_crn           = var.existing_cos_instance_crn
   bucket_access_tags                  = var.bucket_access_tags
   bucket_name                         = var.bucket_name
-  management_endpoint_type_for_bucket = "private"
+  management_endpoint_type_for_bucket = var.management_endpoint_type_for_bucket
   cross_region_location               = var.cross_region_location
   bucket_storage_class                = var.bucket_storage_class
   force_delete                        = var.force_delete

solutions/cross-regional-bucket/security-enforced/variables.tf

@@ -96,6 +96,16 @@ variable "bucket_name" {
   description = "The name to give the newly provisioned Object Storage bucket."
 }
 
+variable "management_endpoint_type_for_bucket" {
+  description = "The type of endpoint for the IBM terraform provider to manage the bucket. Possible values:  `private`, `direct`."
+  type        = string
+  default     = "direct"
+  validation {
+    condition     = contains(["private", "direct"], var.management_endpoint_type_for_bucket)
+    error_message = "The value of management_endpoint_type_for_bucket must be one of: `private`, `direct`."
+  }
+}
+
 variable "cross_region_location" {
   description = "Specify the cross-region bucket location. Possible values: `us`, `eu`, `ap`."
   type        = string

solutions/regional-bucket/fully-configurable/variables.tf

@@ -135,7 +135,7 @@ variable "bucket_name" {
 variable "management_endpoint_type_for_bucket" {
   description = "The type of endpoint for the IBM terraform provider to manage the bucket. Possible values: `public`, `private`, `direct`."
   type        = string
-  default     = "private"
+  default     = "direct"
   validation {
     condition     = contains(["public", "private", "direct"], var.management_endpoint_type_for_bucket)
     error_message = "The value of management_endpoint_type_for_bucket must be one of: `public`, `private`, `direct`."

solutions/regional-bucket/security-enforced/main.tf

@@ -14,7 +14,7 @@ module "regional_bucket" {
   existing_cos_instance_crn           = var.existing_cos_instance_crn
   bucket_access_tags                  = var.bucket_access_tags
   bucket_name                         = var.bucket_name
-  management_endpoint_type_for_bucket = "private"
+  management_endpoint_type_for_bucket = var.management_endpoint_type_for_bucket
   region                              = var.region
   bucket_storage_class                = var.bucket_storage_class
   force_delete                        = var.force_delete

solutions/regional-bucket/security-enforced/variables.tf

@@ -105,6 +105,16 @@ variable "bucket_name" {
   description = "The name to give the newly provisioned Object Storage bucket."
 }
 
+variable "management_endpoint_type_for_bucket" {
+  description = "The type of endpoint for the IBM terraform provider to manage the bucket. Possible values:  `private`, `direct`."
+  type        = string
+  default     = "direct"
+  validation {
+    condition     = contains(["private", "direct"], var.management_endpoint_type_for_bucket)
+    error_message = "The value of management_endpoint_type_for_bucket must be one of: `private`, `direct`."
+  }
+}
+
 variable "bucket_storage_class" {
   type        = string
   description = "The storage class of the newly provisioned Object Storage bucket. Possible values: `standard`, `vault`, `cold`, `smart` `onerate_active`."