Skip to content

Commit 9ed92cf

Browse files
authored
Merge pull request #7 from terraform-google-modules/aaron-lane-revert-master-merge
Revert direct commits to master
2 parents 29d08b6 + 325793e commit 9ed92cf

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ You can go to the examples folder, however the usage of the module could be like
66

77
```hcl
88
module "scheduled-function" {
9-
source = "terraform-google-modules/scheduled-function/google"
9+
source = "terraform-google-modules/scheduled-functions/google"
1010
version = "0.1.0"
1111
project_id = "<PROJECT ID>"
1212
job_name="<NAME_OF_JOB>"
1313
schedule="<CRON_SYNTAX_SCHEDULE"
1414
function_entry_point="<NAME_OF_FUNCTION>"
1515
function_source_directory="<DIRECTORY_OF_FUNCTION_SOURCE>"
16-
function_name="<RESOURCE_NAMES>"
16+
name="<RESOURCE_NAMES>"
1717
region="<REGION>"
1818
}
1919
```

main.tf

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,12 @@
1414
* limitations under the License.
1515
*/
1616

17-
locals {
18-
// we append the app hash to the filename as a temporary workaround for https://github.com/terraform-providers/terraform-provider-google/issues/1938
19-
md5_hash = "${lower(replace(base64encode(data.archive_file.main.output_md5), "=", ""))}"
20-
storage_object_name = "event_function-${random_string.random_suffix.result}-${local.md5_hash}.zip"
21-
}
22-
2317
/******************************************
2418
Scheduled Function Definition
2519
*****************************************/
2620

2721
resource "google_cloud_scheduler_job" "job" {
2822
name = "${var.job_name}"
29-
project = "${var.project_id}"
30-
region = "${var.region}"
3123
description = "${var.job_description}"
3224
schedule = "${var.job_schedule}"
3325
time_zone = "${var.time_zone}"
@@ -100,7 +92,7 @@ resource "google_storage_bucket" "main" {
10092
}
10193

10294
resource "google_storage_bucket_object" "main" {
103-
name = "${local.storage_object_name}"
95+
name = "event_function-${random_string.random_suffix.result}.zip"
10496
bucket = "${google_storage_bucket.main.name}"
10597
source = "${data.archive_file.main.output_path}"
10698
content_disposition = "attachment"

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
variable "project_id" {
18-
description = "The ID of the project where the resources will be created"
18+
description = "The ID of the project where this VPC will be created"
1919
}
2020

2121
variable "job_name" {

0 commit comments

Comments
 (0)