Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output for IPv6 ranges #550

Open
mohag opened this issue Mar 8, 2024 · 5 comments
Open

Output for IPv6 ranges #550

mohag opened this issue Mar 8, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers Stale

Comments

@mohag
Copy link

mohag commented Mar 8, 2024

TL;DR

There is no output for the IPv6 ranges on the subnets. (I'm looking for the ipv6_cidr_range attribute from the google_compute_subnetwork resource) (IPv6 version of the subnets_ips output)

A similar option for internal_ipv6_prefix might be useful as well, but that can be retrieved using the data source. (AFAIK, only one of the two would be present on a single subnet, it might be an option to include whichever one is possible (if any) in the same output)

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_subnetwork#attributes-reference

Detailed design

Add an output `subnets_ipv6s` that outputs `external_ipv6_prefix` for all the subnets (simple copy of `subnets_ips`, with the source attribute changed).

Also add `subnets_internal_ipv6_prefixes` based on `internal_ipv6_prefix` in a similar way.

Additional information

While writing this, I also realised that the subnets output can probably be used to retrieve this info. IPv6 should not be harder to use than IPv4 though.

@mohag mohag added the enhancement New feature or request label Mar 8, 2024
@imrannayer
Copy link
Collaborator

@mohag can u get these values from subnets. It has all the subnet attributes?

@imrannayer imrannayer added the waiting-response Waiting for issue author to respond. label Mar 15, 2024
@mohag
Copy link
Author

mohag commented Mar 15, 2024

@mohag can u get these values from subnets. It has all the subnet attributes?

Correct, that is what I eventually did, see the note in "Additional Information". (So what is left is mainly a request to treat IPv6 and IPv4 the same)

@imrannayer imrannayer added good first issue Good for newcomers and removed waiting-response Waiting for issue author to respond. labels Mar 15, 2024
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

2 participants