-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate network hardcoding (related to #1152, #1153, #1154, #1155) #1226
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
And now it's closed for good w/o any resolution. Much appreciated how it works. |
Github-actions has automation to close issues after 60 days, but that was not the intent. As discussed on our call, this is a priority on our backlog for next quarter when we will have a dedicated team to do a significant refactor on networking issues, including the hardcoding. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
TL;DR
Remove the hardcoding at different levels of IPs and configuration options and instead take the values from a configuration object (which may come from a simple yaml file, or injected by a script). For 3-n-h-a-s an example code and configuration attached. Actually this example attached code (base_env-main.tf.zip) was tested working in a POC on derived TEF fork and removed hardcoding. The actual configuration object coming from the calling module e.g. envs/development (development-main.tf.zip). An example (working & tested) config file attached . Just a working example showing this is possible and even potentially beneficial in terms of consolidating the configuration and streamlining configuration. Just examples (although working) certainly can be optimized or done in other more intelligent way
Attachments:
base_env-main.tf.zip
development-main.tf.zip
vpc_config.yaml.zip
Terraform Resources
Detailed design
N/A (see TL;DR*)
Additional information
Related to #1152 #1153 #1154 #1155
The text was updated successfully, but these errors were encountered: