Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate network hardcoding (related to #1152, #1153, #1154, #1155) #1226

Closed
mromascanu123 opened this issue May 9, 2024 · 4 comments
Closed

Comments

@mromascanu123
Copy link

mromascanu123 commented May 9, 2024

TL;DR

Remove the hardcoding at different levels of IPs and configuration options and instead take the values from a configuration object (which may come from a simple yaml file, or injected by a script). For 3-n-h-a-s an example code and configuration attached. Actually this example attached code (base_env-main.tf.zip) was tested working in a POC on derived TEF fork and removed hardcoding. The actual configuration object coming from the calling module e.g. envs/development (development-main.tf.zip). An example (working & tested) config file attached . Just a working example showing this is possible and even potentially beneficial in terms of consolidating the configuration and streamlining configuration. Just examples (although working) certainly can be optimized or done in other more intelligent way

Attachments:

base_env-main.tf.zip
development-main.tf.zip
vpc_config.yaml.zip

Terraform Resources

N/A

Detailed design

N/A (see TL;DR*)

Additional information

Related to #1152 #1153 #1154 #1155

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jul 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
@mromascanu123
Copy link
Author

And now it's closed for good w/o any resolution. Much appreciated how it works.

@eeaton eeaton reopened this Jul 31, 2024
@eeaton eeaton removed the Stale label Jul 31, 2024
@eeaton
Copy link
Collaborator

eeaton commented Jul 31, 2024

Github-actions has automation to close issues after 60 days, but that was not the intent.

As discussed on our call, this is a priority on our backlog for next quarter when we will have a dedicated team to do a significant refactor on networking issues, including the hardcoding.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 29, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
@daniel-cit daniel-cit removed the Stale label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants