Skip to content

fix: Remove restriction on engine to allow Valkey cluster creation #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

fix: Remove restriction on engine to allow Valkey cluster creation #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ locals {
# https://github.com/hashicorp/terraform-provider-aws/blob/3c4cb52c5dc2c09e10e5a717f73d1d8bc4186e87/internal/service/elasticache/cluster.go#L271
in_replication_group = var.replication_group_id != null

# elasticache clusters currently do not support engine type valkey
# TODO: remove this local `create_cluster` conditional once this bug is addressed:
# https://github.com/hashicorp/terraform-provider-aws/issues/39905
create_cluster = var.create_cluster && var.engine != "valkey" ? true : false

security_group_ids = local.create_security_group ? concat(var.security_group_ids, [aws_security_group.this[0].id]) : var.security_group_ids
port = var.engine == "memcached" ? 11211 : 6379

Expand All @@ -18,7 +13,7 @@ locals {
################################################################################

resource "aws_elasticache_cluster" "this" {
count = var.create && local.create_cluster ? 1 : 0
count = var.create && var.create_cluster ? 1 : 0

apply_immediately = var.apply_immediately
auto_minor_version_upgrade = var.auto_minor_version_upgrade
Expand Down
Loading