Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tutorial directory a variable (and don't run jupyter as root) #176

Open
ofenloch opened this issue Apr 2, 2024 · 0 comments
Open
Labels
sig build dockerfiles Relating to the TF SIG Build Dockerfiles

Comments

@ofenloch
Copy link

ofenloch commented Apr 2, 2024

Instead of the hardcoded "/tf" a variable ${TENSORFLOW_NOTEBOOK_DIR} should be used.

When I derived my own image from one of yours I let jupyter notebook run as non-root user and could not access the tensorflow-tutorials notebooks in /tf/tensorflow-tutorials.

In the long run, jupyter should not run as root - and users shouldn't have to adjust this on their own.

@ofenloch ofenloch added the sig build dockerfiles Relating to the TF SIG Build Dockerfiles label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig build dockerfiles Relating to the TF SIG Build Dockerfiles
Projects
None yet
Development

No branches or pull requests

1 participant