Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpinnerButton: live region can be reached navigating by element using a screen reader #36

Open
jfhector opened this issue Oct 16, 2019 · 0 comments

Comments

@jfhector
Copy link

First, thanks a lot for publishing TenonUI. It's been a fantastically helpful learning resource for me.

I've noticed a small issue with the SpinnerButton.

Steps to reproduce

  1. Go to the SpinnerButton demo page
  2. Activate a screen reader, if you don't already have one running
  3. Place the screen reader cursor on the demo button (labelled 'Click me')
  4. Activate the demo spinner button
  5. Wait a bit, long enough to each both the 'The async action is busy' and 'The async action is complete' announcements
  6. Navigate to the two previous DOM elements using your screen reader (e.g. VO + Left Arrow, or Up Arrow on NVDA).

Observed outcome

You will hear 'The async action is complete' as you navigate the DOM element by element.

This can be confusing, as the action has completed long ago. The announcement is now heard out of context and might create confusion.

Observed with:
  • MacOS 10.14 (Mojave) + VoiceOver + latest Safari
  • MacOS 10.14 (Mojave) + VoiceOver + latest Chrome
  • Windows 10 + latest Chrome + latest NVDA

Expected outcome

I expected to not hear a 'the async action is complete' announcement out of context, when traversing the DOM with a screen reader, long after I've clicked a button.

Suggestion

I imagine that it'd be an improvement to empty the content of each live region 500ms or so after they have been populated, so they don't stay populated in the DOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant