Merge pull request #98 from teng-lin/refactor/remove-backward-compat

refactor: remove 7 backward-compatibility shims

Author: teng-lin

src/adapters/claude/claude-launcher.ts

@@ -427,11 +427,6 @@ export class ClaudeLauncher extends ProcessSupervisor<LauncherEventMap> implemen
     }
   }
 
-  /** @deprecated Use setBackendSessionId */
-  setCLISessionId(sessionId: string, backendSessionId: string): void {
-    this.setBackendSessionId(sessionId, backendSessionId);
-  }
-
   // ---------------------------------------------------------------------------
   // Kill / Cleanup
   // ---------------------------------------------------------------------------

src/adapters/claude/inbound-translator.test.ts

@@ -1,7 +1,8 @@
 import { describe, expect, it } from "vitest";
+import { normalizeInbound } from "../../core/inbound-normalizer.js";
 import { createUnifiedMessage } from "../../core/types/unified-message.js";
 import type { InboundMessage } from "../../types/inbound-messages.js";
-import { normalizeInbound, toNDJSON } from "./inbound-translator.js";
+import { toNDJSON } from "./inbound-translator.js";
 
 // ---------------------------------------------------------------------------
 // normalizeInbound

src/adapters/claude/inbound-translator.ts

@@ -1,16 +1,11 @@
 /**
  * Claude Inbound Translator
  *
- * Two responsibilities:
- * 1. normalizeInbound: Re-exported from core (generic InboundMessage → UnifiedMessage)
- * 2. toNDJSON: UnifiedMessage → NDJSON string (Claude-specific wire format)
+ * Converts UnifiedMessage → NDJSON string (Claude-specific wire format).
  */
 
 import type { UnifiedMessage } from "../../core/types/unified-message.js";
 
-// Re-export normalizeInbound from core for backward compatibility
-export { normalizeInbound } from "../../core/inbound-normalizer.js";
-
 // ---------------------------------------------------------------------------
 // UnifiedMessage → NDJSON string (for CLI)
 // ---------------------------------------------------------------------------

src/adapters/claude/index.ts

@@ -1,4 +1,5 @@
+export { normalizeInbound } from "../../core/inbound-normalizer.js";
+export { reduce } from "../../core/session-state-reducer.js";
 export { ClaudeAdapter } from "./claude-adapter.js";
-export { normalizeInbound, toNDJSON } from "./inbound-translator.js";
+export { toNDJSON } from "./inbound-translator.js";
 export { translate } from "./message-translator.js";
-export { reduce } from "./state-reducer.js";

src/adapters/claude/message-translator.test.ts

@@ -31,7 +31,6 @@ function makeInitMsg(overrides?: Partial<CLISystemInitMessage>): CLISystemInitMe
     apiKeySource: "env",
     claude_code_version: "1.0.0",
     slash_commands: ["/help", "/clear"],
-    agents: ["planner"],
     skills: ["tdd"],
     output_style: "streaming",
     uuid: "uuid-init-1",
@@ -120,22 +119,19 @@ describe("message-translator", () => {
       expect(result.metadata.apiKeySource).toBe("env");
       expect(result.metadata.claude_code_version).toBe("1.0.0");
       expect(result.metadata.mcp_servers).toEqual([{ name: "local", status: "connected" }]);
-      expect(result.metadata.agents).toEqual(["planner"]);
       expect(result.metadata.slash_commands).toEqual(["/help", "/clear"]);
       expect(result.metadata.skills).toEqual(["tdd"]);
       expect(result.metadata.output_style).toBe("streaming");
       expect(result.metadata.session_id).toBe("sess-1");
       expect(result.metadata.uuid).toBe("uuid-init-1");
     });
 
-    it("defaults agents/slash_commands/skills to empty arrays when undefined", () => {
+    it("defaults slash_commands/skills to empty arrays when undefined", () => {
       const msg = makeInitMsg({
-        agents: undefined,
         slash_commands: undefined as unknown as string[],
         skills: undefined,
       });
       const result = translate(msg)!;
-      expect(result.metadata.agents).toEqual([]);
       expect(result.metadata.slash_commands).toEqual([]);
       expect(result.metadata.skills).toEqual([]);
     });

src/adapters/claude/message-translator.ts

@@ -71,7 +71,6 @@ function translateSystemInit(msg: CLISystemInitMessage): UnifiedMessage {
       apiKeySource: msg.apiKeySource,
       claude_code_version: msg.claude_code_version,
       mcp_servers: msg.mcp_servers,
-      agents: msg.agents ?? [],
       slash_commands: msg.slash_commands ?? [],
       skills: msg.skills ?? [],
       output_style: msg.output_style,

src/adapters/claude/state-reducer.property.test.ts

@@ -1,8 +1,8 @@
 import fc from "fast-check";
 import { describe, expect, it } from "vitest";
+import { reduce } from "../../core/session-state-reducer.js";
 import { createUnifiedMessage } from "../../core/types/unified-message.js";
 import type { SessionState } from "../../types/session-state.js";
-import { reduce } from "./state-reducer.js";
 
 function arbSessionState(): fc.Arbitrary<SessionState> {
   return fc.record({
@@ -13,7 +13,6 @@ function arbSessionState(): fc.Arbitrary<SessionState> {
     permissionMode: fc.string(),
     claude_code_version: fc.string(),
     mcp_servers: fc.array(fc.record({ name: fc.string(), status: fc.string() })),
-    agents: fc.array(fc.string()),
     slash_commands: fc.array(fc.string()),
     skills: fc.array(fc.string()),
     is_compacting: fc.boolean(),

src/adapters/claude/state-reducer.test.ts

@@ -1,8 +1,8 @@
 import { describe, expect, it } from "vitest";
+import { reduce } from "../../core/session-state-reducer.js";
 import { createUnifiedMessage } from "../../core/types/unified-message.js";
 import { makeDefaultSessionState, makeToolUseMessage } from "../../testing/fixtures.js";
 import type { SessionState } from "../../types/session-state.js";
-import { reduce } from "./state-reducer.js";
 
 // ---------------------------------------------------------------------------
 // Tests
@@ -22,7 +22,6 @@ describe("state-reducer", () => {
           permissionMode: "plan",
           claude_code_version: "1.0.0",
           mcp_servers: [{ name: "local", status: "connected" }],
-          agents: ["planner"],
           slash_commands: ["/help"],
           skills: ["tdd"],
         },
@@ -37,7 +36,6 @@ describe("state-reducer", () => {
       expect(next.permissionMode).toBe("plan");
       expect(next.claude_code_version).toBe("1.0.0");
       expect(next.mcp_servers).toEqual([{ name: "local", status: "connected" }]);
-      expect(next.agents).toEqual(["planner"]);
       expect(next.slash_commands).toEqual(["/help"]);
       expect(next.skills).toEqual(["tdd"]);
     });
@@ -279,7 +277,6 @@ describe("state-reducer", () => {
       );
       expect(next.team!.members).toHaveLength(1);
       expect(next.team!.members[0]!.name).toBe("worker-1");
-      expect(next.agents).toEqual(["worker-1"]);
     });
 
     it("applies TaskCreate with synthetic ID when no tool_result", () => {

src/adapters/claude/state-reducer.ts

@@ -6,6 +6,7 @@
  */
 
 import { beforeEach, describe, expect, it } from "vitest";
+import { reduce } from "../../core/session-state-reducer.js";
 import { TeamToolCorrelationBuffer } from "../../core/team-tool-correlation.js";
 import { createUnifiedMessage } from "../../core/types/unified-message.js";
 import {
@@ -14,7 +15,6 @@ import {
   makeToolUseMessage,
 } from "../../testing/fixtures.js";
 import type { SessionState } from "../../types/session-state.js";
-import { reduce } from "./state-reducer.js";
 
 // ---------------------------------------------------------------------------
 // Tests
@@ -85,26 +85,8 @@ describe("state-reducer team integration", () => {
     });
   });
 
-  describe("backward compatibility", () => {
-    it("populates agents[] from team.members", () => {
-      const state: SessionState = {
-        ...makeDefaultSessionState(),
-        team: { name: "my-team", role: "lead", members: [], tasks: [] },
-      };
-
-      const s1 = reduce(
-        state,
-        makeToolUseMessage("Task", "tu-2", { team_name: "my-team", name: "worker-1" }),
-        buffer,
-      );
-      const s2 = reduce(s1, makeToolResultMessage("tu-2", "{}"), buffer);
-
-      expect(s2.agents).toEqual(["worker-1"]);
-    });
-  });
-
   describe("TeamDelete", () => {
-    it("removes team and resets agents to []", () => {
+    it("removes team state", () => {
       const state: SessionState = {
         ...makeDefaultSessionState(),
         team: {
@@ -115,14 +97,12 @@ describe("state-reducer team integration", () => {
           ],
           tasks: [],
         },
-        agents: ["worker-1"],
       };
 
       const s1 = reduce(state, makeToolUseMessage("TeamDelete", "tu-del", {}), buffer);
       const s2 = reduce(s1, makeToolResultMessage("tu-del", '{"success": true}'), buffer);
 
       expect(s2.team).toBeUndefined();
-      expect(s2.agents).toEqual([]);
     });
   });
 
@@ -183,7 +163,7 @@ describe("state-reducer team integration", () => {
         buffer,
       );
       expect(state.team?.members).toHaveLength(1);
-      expect(state.agents).toEqual(["dev-1"]);
+      expect(state.team!.members[0]!.name).toBe("dev-1");
 
       // Create task — optimistic with synthetic ID
       state = reduce(
@@ -206,7 +186,7 @@ describe("state-reducer team integration", () => {
       // Delete team — optimistic
       state = reduce(state, makeToolUseMessage("TeamDelete", "tu-5", {}), buffer);
       expect(state.team).toBeUndefined();
-      expect(state.agents).toEqual([]);
+      expect(state.team).toBeUndefined();
     });
 
     it("dual-path: tool_use + tool_result — synthetic replaced by real ID", () => {
@@ -268,7 +248,8 @@ describe("state-reducer team integration", () => {
       );
       expect(state.team!.members).toHaveLength(1);
       expect(state.team!.members[0]!.name).toBe("researcher");
-      expect(state.agents).toEqual(["researcher"]);
+      expect(state.team!.members).toHaveLength(1);
+      expect(state.team!.members[0]!.name).toBe("researcher");
 
       // Second member
       state = reduce(
@@ -277,7 +258,8 @@ describe("state-reducer team integration", () => {
         buffer,
       );
       expect(state.team!.members).toHaveLength(2);
-      expect(state.agents).toEqual(["researcher", "implementer"]);
+      expect(state.team!.members).toHaveLength(2);
+      expect(state.team!.members.map((m) => m.name)).toEqual(["researcher", "implementer"]);
 
       // TaskCreate — uses synthetic ID since no tool_result
       state = reduce(