Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceBasedSlotSupplier.ReleaseSlot not implemented #1868

Open
captchanjack-anzx opened this issue Mar 13, 2025 · 0 comments
Open

ResourceBasedSlotSupplier.ReleaseSlot not implemented #1868

captchanjack-anzx opened this issue Mar 13, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@captchanjack-anzx
Copy link

Expected Behavior

Activity SlotSupplier created with resourcetuner.NewResourceBasedSlotSupplier should release activity slots when they are completed.

Actual Behavior

Activity slots are not released after task is completed. This causes scheduled activities to forever hand in PENDING_ACTIVITY_STATE_SCHEDULED state.

I suspect because the SlotSupplier interface method ReleaseSlot is not implemented:

https://github.com/temporalio/sdk-go/blob/master/contrib/resourcetuner/resourcetuner.go#L204

Steps to Reproduce the Problem

  1. Create a tuner with worker.NewCompositeTuner and resourcetuner.NewResourceBasedSlotSupplier as suggested in go-sdk docs
  2. Set activity ResourceBasedSlotSupplierOptions.MaxSlots to something small like 4.
  3. Start a worker with tuner set in worker.Options
  4. Execute a workflow that starts a large amount of activities - few activities should be scheduled, and others should be schedule/stuck in pending state.

Specifications

  • Version:
      go.temporal.io/api v1.44.1
  go.temporal.io/sdk v1.33.0
  go.temporal.io/sdk/contrib/resourcetuner v0.0.0-20250227195219-884681f7392e
  • Platform: GCP Cloud Run, 8 cores 8GiB per instance, unsure chip used (i think amd based)
@captchanjack-anzx captchanjack-anzx added the bug Something isn't working label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant