Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy gRPC interceptors in api-go should visit payloads and failures of gRPC errors too #1825

Open
cretz opened this issue Feb 14, 2025 · 0 comments
Open

Proxy gRPC interceptors in api-go should visit payloads and failures of gRPC errors too #1825

cretz opened this issue Feb 14, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Feb 14, 2025

Describe the solution you'd like

In api-go, NewPayloadVisitorInterceptor should visit payloads in the status details of gRPC errors as well, and NewFailureVisitorInterceptor should do the same for visiting failures. Try to keep in mind performance, but there may be no choice but to unpack the any, visit, and repack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cretz