Skip to content

Commit e829ad7

Browse files
alexshtinalexshtin
authored
Rename ID to Id in proto files (#82)
1 parent 51e1705 commit e829ad7

7 files changed

+63
-63
lines changed

‎go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ require (
2222
github.com/uber-go/tally v3.3.15+incompatible
2323
github.com/uber/jaeger-client-go v2.22.1+incompatible
2424
github.com/uber/jaeger-lib v2.2.0+incompatible // indirect
25-
go.temporal.io/temporal-proto v0.20.2
25+
go.temporal.io/temporal-proto v0.20.4
2626
go.uber.org/atomic v1.6.0
2727
go.uber.org/goleak v1.0.0
2828
go.uber.org/zap v1.14.1

‎go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ github.com/uber/jaeger-client-go v2.22.1+incompatible/go.mod h1:WVhlPFC8FDjOFMMW
9191
github.com/uber/jaeger-lib v2.2.0+incompatible h1:MxZXOiR2JuoANZ3J6DE/U0kSFv/eJ/GfSYVCjK7dyaw=
9292
github.com/uber/jaeger-lib v2.2.0+incompatible/go.mod h1:ComeNDZlWwrWnDv8aPp0Ba6+uUTzImX/AauajbLI56U=
9393
github.com/yuin/goldmark v1.1.25/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
94-
go.temporal.io/temporal-proto v0.20.2 h1:ll+VJaxyR4xzZWClT+CIcm4fQdzEdcBGf4Yksq4EVxI=
95-
go.temporal.io/temporal-proto v0.20.2/go.mod h1:Lv8L8YBpbp0Z7V5nbvw5UD0j7x0isebhCOIDLkBqn6s=
94+
go.temporal.io/temporal-proto v0.20.4 h1:mjuMZ9UCVBg4rfH8LDDwI76XjIfxurzsf94tOPXhTEs=
95+
go.temporal.io/temporal-proto v0.20.4/go.mod h1:Lv8L8YBpbp0Z7V5nbvw5UD0j7x0isebhCOIDLkBqn6s=
9696
go.uber.org/atomic v1.6.0 h1:Ezj3JGmsOnG1MoRWQkPBsKLe9DwWD9QeXzTRzzldNVk=
9797
go.uber.org/atomic v1.6.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
9898
go.uber.org/goleak v1.0.0 h1:qsup4IcBdlmsnGfqyLl4Ntn3C2XCCuKAE7DwHpScyUo=

‎internal/common/metrics/service_wrapper.go

+12-12
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ const (
5454
scopeNamePollForActivityTask = TemporalMetricsPrefix + "PollForActivityTask"
5555
scopeNamePollForDecisionTask = TemporalMetricsPrefix + "PollForDecisionTask"
5656
scopeNameRecordActivityTaskHeartbeat = TemporalMetricsPrefix + "RecordActivityTaskHeartbeat"
57-
scopeNameRecordActivityTaskHeartbeatByID = TemporalMetricsPrefix + "RecordActivityTaskHeartbeatByID"
57+
scopeNameRecordActivityTaskHeartbeatByID = TemporalMetricsPrefix + "RecordActivityTaskHeartbeatById"
5858
scopeNameRegisterNamespace = TemporalMetricsPrefix + "RegisterNamespace"
5959
scopeNameRequestCancelWorkflowExecution = TemporalMetricsPrefix + "RequestCancelWorkflowExecution"
6060
scopeNameRespondActivityTaskCanceled = TemporalMetricsPrefix + "RespondActivityTaskCanceled"
6161
scopeNameRespondActivityTaskCompleted = TemporalMetricsPrefix + "RespondActivityTaskCompleted"
6262
scopeNameRespondActivityTaskFailed = TemporalMetricsPrefix + "RespondActivityTaskFailed"
63-
scopeNameRespondActivityTaskCanceledByID = TemporalMetricsPrefix + "RespondActivityTaskCanceledByID"
64-
scopeNameRespondActivityTaskCompletedByID = TemporalMetricsPrefix + "RespondActivityTaskCompletedByID"
65-
scopeNameRespondActivityTaskFailedByID = TemporalMetricsPrefix + "RespondActivityTaskFailedByID"
63+
scopeNameRespondActivityTaskCanceledByID = TemporalMetricsPrefix + "RespondActivityTaskCanceledById"
64+
scopeNameRespondActivityTaskCompletedByID = TemporalMetricsPrefix + "RespondActivityTaskCompletedById"
65+
scopeNameRespondActivityTaskFailedByID = TemporalMetricsPrefix + "RespondActivityTaskFailedById"
6666
scopeNameRespondDecisionTaskCompleted = TemporalMetricsPrefix + "RespondDecisionTaskCompleted"
6767
scopeNameRespondDecisionTaskFailed = TemporalMetricsPrefix + "RespondDecisionTaskFailed"
6868
scopeNameSignalWorkflowExecution = TemporalMetricsPrefix + "SignalWorkflowExecution"
@@ -216,9 +216,9 @@ func (w *workflowServiceMetricsWrapper) RecordActivityTaskHeartbeat(ctx context.
216216
return result, err
217217
}
218218

219-
func (w *workflowServiceMetricsWrapper) RecordActivityTaskHeartbeatByID(ctx context.Context, request *workflowservice.RecordActivityTaskHeartbeatByIDRequest, opts ...grpc.CallOption) (*workflowservice.RecordActivityTaskHeartbeatByIDResponse, error) {
219+
func (w *workflowServiceMetricsWrapper) RecordActivityTaskHeartbeatById(ctx context.Context, request *workflowservice.RecordActivityTaskHeartbeatByIdRequest, opts ...grpc.CallOption) (*workflowservice.RecordActivityTaskHeartbeatByIdResponse, error) {
220220
scope := w.getOperationScope(scopeNameRecordActivityTaskHeartbeatByID)
221-
result, err := w.service.RecordActivityTaskHeartbeatByID(ctx, request, opts...)
221+
result, err := w.service.RecordActivityTaskHeartbeatById(ctx, request, opts...)
222222
scope.handleError(err)
223223
return result, err
224224
}
@@ -258,23 +258,23 @@ func (w *workflowServiceMetricsWrapper) RespondActivityTaskFailed(ctx context.Co
258258
return result, err
259259
}
260260

261-
func (w *workflowServiceMetricsWrapper) RespondActivityTaskCanceledByID(ctx context.Context, request *workflowservice.RespondActivityTaskCanceledByIDRequest, opts ...grpc.CallOption) (*workflowservice.RespondActivityTaskCanceledByIDResponse, error) {
261+
func (w *workflowServiceMetricsWrapper) RespondActivityTaskCanceledById(ctx context.Context, request *workflowservice.RespondActivityTaskCanceledByIdRequest, opts ...grpc.CallOption) (*workflowservice.RespondActivityTaskCanceledByIdResponse, error) {
262262
scope := w.getOperationScope(scopeNameRespondActivityTaskCanceledByID)
263-
result, err := w.service.RespondActivityTaskCanceledByID(ctx, request, opts...)
263+
result, err := w.service.RespondActivityTaskCanceledById(ctx, request, opts...)
264264
scope.handleError(err)
265265
return result, err
266266
}
267267

268-
func (w *workflowServiceMetricsWrapper) RespondActivityTaskCompletedByID(ctx context.Context, request *workflowservice.RespondActivityTaskCompletedByIDRequest, opts ...grpc.CallOption) (*workflowservice.RespondActivityTaskCompletedByIDResponse, error) {
268+
func (w *workflowServiceMetricsWrapper) RespondActivityTaskCompletedById(ctx context.Context, request *workflowservice.RespondActivityTaskCompletedByIdRequest, opts ...grpc.CallOption) (*workflowservice.RespondActivityTaskCompletedByIdResponse, error) {
269269
scope := w.getOperationScope(scopeNameRespondActivityTaskCompletedByID)
270-
result, err := w.service.RespondActivityTaskCompletedByID(ctx, request, opts...)
270+
result, err := w.service.RespondActivityTaskCompletedById(ctx, request, opts...)
271271
scope.handleError(err)
272272
return result, err
273273
}
274274

275-
func (w *workflowServiceMetricsWrapper) RespondActivityTaskFailedByID(ctx context.Context, request *workflowservice.RespondActivityTaskFailedByIDRequest, opts ...grpc.CallOption) (*workflowservice.RespondActivityTaskFailedByIDResponse, error) {
275+
func (w *workflowServiceMetricsWrapper) RespondActivityTaskFailedById(ctx context.Context, request *workflowservice.RespondActivityTaskFailedByIdRequest, opts ...grpc.CallOption) (*workflowservice.RespondActivityTaskFailedByIdResponse, error) {
276276
scope := w.getOperationScope(scopeNameRespondActivityTaskFailedByID)
277-
result, err := w.service.RespondActivityTaskFailedByID(ctx, request, opts...)
277+
result, err := w.service.RespondActivityTaskFailedById(ctx, request, opts...)
278278
scope.handleError(err)
279279
return result, err
280280
}

‎internal/common/metrics/service_wrapper_test.go

+11-11
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ func Test_Wrapper(t *testing.T) {
8282
{"RespondActivityTaskCanceled", []interface{}{ctx, &workflowservice.RespondActivityTaskCanceledRequest{}}, []interface{}{&workflowservice.RespondActivityTaskCanceledResponse{}, nil}, []string{TemporalRequest}},
8383
{"RespondActivityTaskCompleted", []interface{}{ctx, &workflowservice.RespondActivityTaskCompletedRequest{}}, []interface{}{&workflowservice.RespondActivityTaskCompletedResponse{}, nil}, []string{TemporalRequest}},
8484
{"RespondActivityTaskFailed", []interface{}{ctx, &workflowservice.RespondActivityTaskFailedRequest{}}, []interface{}{&workflowservice.RespondActivityTaskFailedResponse{}, nil}, []string{TemporalRequest}},
85-
{"RespondActivityTaskCanceledByID", []interface{}{ctx, &workflowservice.RespondActivityTaskCanceledByIDRequest{}}, []interface{}{&workflowservice.RespondActivityTaskCanceledByIDResponse{}, nil}, []string{TemporalRequest}},
86-
{"RespondActivityTaskCompletedByID", []interface{}{ctx, &workflowservice.RespondActivityTaskCompletedByIDRequest{}}, []interface{}{&workflowservice.RespondActivityTaskCompletedByIDResponse{}, nil}, []string{TemporalRequest}},
87-
{"RespondActivityTaskFailedByID", []interface{}{ctx, &workflowservice.RespondActivityTaskFailedByIDRequest{}}, []interface{}{&workflowservice.RespondActivityTaskFailedByIDResponse{}, nil}, []string{TemporalRequest}},
85+
{"RespondActivityTaskCanceledById", []interface{}{ctx, &workflowservice.RespondActivityTaskCanceledByIdRequest{}}, []interface{}{&workflowservice.RespondActivityTaskCanceledByIdResponse{}, nil}, []string{TemporalRequest}},
86+
{"RespondActivityTaskCompletedById", []interface{}{ctx, &workflowservice.RespondActivityTaskCompletedByIdRequest{}}, []interface{}{&workflowservice.RespondActivityTaskCompletedByIdResponse{}, nil}, []string{TemporalRequest}},
87+
{"RespondActivityTaskFailedById", []interface{}{ctx, &workflowservice.RespondActivityTaskFailedByIdRequest{}}, []interface{}{&workflowservice.RespondActivityTaskFailedByIdResponse{}, nil}, []string{TemporalRequest}},
8888
{"RespondDecisionTaskCompleted", []interface{}{ctx, &workflowservice.RespondDecisionTaskCompletedRequest{}}, []interface{}{nil, nil}, []string{TemporalRequest}},
8989
{"SignalWorkflowExecution", []interface{}{ctx, &workflowservice.SignalWorkflowExecutionRequest{}}, []interface{}{&workflowservice.SignalWorkflowExecutionResponse{}, nil}, []string{TemporalRequest}},
9090
{"StartWorkflowExecution", []interface{}{ctx, &workflowservice.StartWorkflowExecutionRequest{}}, []interface{}{&workflowservice.StartWorkflowExecutionResponse{}, nil}, []string{TemporalRequest}},
@@ -137,8 +137,8 @@ func runTest(
137137
mockService.EXPECT().PollForDecisionTask(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
138138
case "RecordActivityTaskHeartbeat":
139139
mockService.EXPECT().RecordActivityTaskHeartbeat(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
140-
case "RecordActivityTaskHeartbeatByID":
141-
mockService.EXPECT().RecordActivityTaskHeartbeatByID(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
140+
case "RecordActivityTaskHeartbeatById":
141+
mockService.EXPECT().RecordActivityTaskHeartbeatById(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
142142
case "RegisterNamespace":
143143
mockService.EXPECT().RegisterNamespace(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
144144
case "RequestCancelWorkflowExecution":
@@ -149,12 +149,12 @@ func runTest(
149149
mockService.EXPECT().RespondActivityTaskCompleted(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
150150
case "RespondActivityTaskFailed":
151151
mockService.EXPECT().RespondActivityTaskFailed(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
152-
case "RespondActivityTaskCanceledByID":
153-
mockService.EXPECT().RespondActivityTaskCanceledByID(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
154-
case "RespondActivityTaskCompletedByID":
155-
mockService.EXPECT().RespondActivityTaskCompletedByID(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
156-
case "RespondActivityTaskFailedByID":
157-
mockService.EXPECT().RespondActivityTaskFailedByID(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
152+
case "RespondActivityTaskCanceledById":
153+
mockService.EXPECT().RespondActivityTaskCanceledById(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
154+
case "RespondActivityTaskCompletedById":
155+
mockService.EXPECT().RespondActivityTaskCompletedById(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
156+
case "RespondActivityTaskFailedById":
157+
mockService.EXPECT().RespondActivityTaskFailedById(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
158158
case "RespondDecisionTaskCompleted":
159159
mockService.EXPECT().RespondDecisionTaskCompleted(gomock.Any(), gomock.Any(), gomock.Any()).Return(returns...)
160160
case "SignalWorkflowExecution":

‎internal/internal_task_handlers.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -1880,22 +1880,22 @@ func recordActivityHeartbeatByID(
18801880
namespace, workflowID, runID, activityID string,
18811881
details []byte,
18821882
) error {
1883-
request := &workflowservice.RecordActivityTaskHeartbeatByIDRequest{
1883+
request := &workflowservice.RecordActivityTaskHeartbeatByIdRequest{
18841884
Namespace: namespace,
1885-
WorkflowID: workflowID,
1886-
RunID: runID,
1887-
ActivityID: activityID,
1885+
WorkflowId: workflowID,
1886+
RunId: runID,
1887+
ActivityId: activityID,
18881888
Details: details,
18891889
Identity: identity}
18901890

1891-
var heartbeatResponse *workflowservice.RecordActivityTaskHeartbeatByIDResponse
1891+
var heartbeatResponse *workflowservice.RecordActivityTaskHeartbeatByIdResponse
18921892
heartbeatErr := backoff.Retry(ctx,
18931893
func() error {
18941894
tchCtx, cancel := newChannelContext(ctx)
18951895
defer cancel()
18961896

18971897
var err error
1898-
heartbeatResponse, err = service.RecordActivityTaskHeartbeatByID(tchCtx, request)
1898+
heartbeatResponse, err = service.RecordActivityTaskHeartbeatById(tchCtx, request)
18991899
return err
19001900
}, createDynamicServiceRetryPolicy(ctx), isServiceTransientError)
19011901

‎internal/internal_task_pollers.go

+21-21
Original file line numberDiff line numberDiff line change
@@ -940,41 +940,41 @@ func reportActivityCompleteByID(ctx context.Context, service workflowservice.Wor
940940

941941
var reportErr error
942942
switch request := request.(type) {
943-
case *workflowservice.RespondActivityTaskCanceledByIDRequest:
943+
case *workflowservice.RespondActivityTaskCanceledByIdRequest:
944944
reportErr = backoff.Retry(ctx,
945945
func() error {
946946
tchCtx, cancel := newChannelContext(ctx)
947947
defer cancel()
948948

949-
_, err := service.RespondActivityTaskCanceledByID(tchCtx, request)
949+
_, err := service.RespondActivityTaskCanceledById(tchCtx, request)
950950
return err
951951
}, createDynamicServiceRetryPolicy(ctx), isServiceTransientError)
952-
case *workflowservice.RespondActivityTaskFailedByIDRequest:
952+
case *workflowservice.RespondActivityTaskFailedByIdRequest:
953953
reportErr = backoff.Retry(ctx,
954954
func() error {
955955
tchCtx, cancel := newChannelContext(ctx)
956956
defer cancel()
957957

958-
_, err := service.RespondActivityTaskFailedByID(tchCtx, request)
958+
_, err := service.RespondActivityTaskFailedById(tchCtx, request)
959959
return err
960960
}, createDynamicServiceRetryPolicy(ctx), isServiceTransientError)
961-
case *workflowservice.RespondActivityTaskCompletedByIDRequest:
961+
case *workflowservice.RespondActivityTaskCompletedByIdRequest:
962962
reportErr = backoff.Retry(ctx,
963963
func() error {
964964
tchCtx, cancel := newChannelContext(ctx)
965965
defer cancel()
966966

967-
_, err := service.RespondActivityTaskCompletedByID(tchCtx, request)
967+
_, err := service.RespondActivityTaskCompletedById(tchCtx, request)
968968
return err
969969
}, createDynamicServiceRetryPolicy(ctx), isServiceTransientError)
970970
}
971971
if reportErr == nil {
972972
switch request.(type) {
973-
case *workflowservice.RespondActivityTaskCanceledByIDRequest:
973+
case *workflowservice.RespondActivityTaskCanceledByIdRequest:
974974
metricsScope.Counter(metrics.ActivityTaskCanceledByIDCounter).Inc(1)
975-
case *workflowservice.RespondActivityTaskFailedByIDRequest:
975+
case *workflowservice.RespondActivityTaskFailedByIdRequest:
976976
metricsScope.Counter(metrics.ActivityTaskFailedByIDCounter).Inc(1)
977-
case *workflowservice.RespondActivityTaskCompletedByIDRequest:
977+
case *workflowservice.RespondActivityTaskCompletedByIdRequest:
978978
metricsScope.Counter(metrics.ActivityTaskCompletedByIDCounter).Inc(1)
979979
}
980980
}
@@ -1021,31 +1021,31 @@ func convertActivityResultToRespondRequestByID(identity, namespace, workflowID,
10211021
}
10221022

10231023
if err == nil {
1024-
return &workflowservice.RespondActivityTaskCompletedByIDRequest{
1024+
return &workflowservice.RespondActivityTaskCompletedByIdRequest{
10251025
Namespace: namespace,
1026-
WorkflowID: workflowID,
1027-
RunID: runID,
1028-
ActivityID: activityID,
1026+
WorkflowId: workflowID,
1027+
RunId: runID,
1028+
ActivityId: activityID,
10291029
Result: result,
10301030
Identity: identity}
10311031
}
10321032

10331033
reason, details := getErrorDetails(err, dataConverter)
10341034
if _, ok := err.(*CanceledError); ok || err == context.Canceled {
1035-
return &workflowservice.RespondActivityTaskCanceledByIDRequest{
1035+
return &workflowservice.RespondActivityTaskCanceledByIdRequest{
10361036
Namespace: namespace,
1037-
WorkflowID: workflowID,
1038-
RunID: runID,
1039-
ActivityID: activityID,
1037+
WorkflowId: workflowID,
1038+
RunId: runID,
1039+
ActivityId: activityID,
10401040
Details: details,
10411041
Identity: identity}
10421042
}
10431043

1044-
return &workflowservice.RespondActivityTaskFailedByIDRequest{
1044+
return &workflowservice.RespondActivityTaskFailedByIdRequest{
10451045
Namespace: namespace,
1046-
WorkflowID: workflowID,
1047-
RunID: runID,
1048-
ActivityID: activityID,
1046+
WorkflowId: workflowID,
1047+
RunId: runID,
1048+
ActivityId: activityID,
10491049
Reason: reason,
10501050
Details: details,
10511051
Identity: identity}

‎internal/internal_worker_test.go

+10-10
Original file line numberDiff line numberDiff line change
@@ -645,16 +645,16 @@ func (s *internalWorkerTestSuite) TestCompleteActivityById() {
645645
mockService := s.service
646646
wfClient := NewServiceClient(mockService, nil, ClientOptions{Namespace: "testNamespace"})
647647
var completedRequest, canceledRequest, failedRequest interface{}
648-
mockService.EXPECT().RespondActivityTaskCompletedByID(gomock.Any(), gomock.Any(), gomock.Any()).Return(&workflowservice.RespondActivityTaskCompletedByIDResponse{}, nil).Do(
649-
func(ctx context.Context, request *workflowservice.RespondActivityTaskCompletedByIDRequest, opts ...grpc.CallOption) {
648+
mockService.EXPECT().RespondActivityTaskCompletedById(gomock.Any(), gomock.Any(), gomock.Any()).Return(&workflowservice.RespondActivityTaskCompletedByIdResponse{}, nil).Do(
649+
func(ctx context.Context, request *workflowservice.RespondActivityTaskCompletedByIdRequest, opts ...grpc.CallOption) {
650650
completedRequest = request
651651
})
652-
mockService.EXPECT().RespondActivityTaskCanceledByID(gomock.Any(), gomock.Any(), gomock.Any()).Return(&workflowservice.RespondActivityTaskCanceledByIDResponse{}, nil).Do(
653-
func(ctx context.Context, request *workflowservice.RespondActivityTaskCanceledByIDRequest, opts ...grpc.CallOption) {
652+
mockService.EXPECT().RespondActivityTaskCanceledById(gomock.Any(), gomock.Any(), gomock.Any()).Return(&workflowservice.RespondActivityTaskCanceledByIdResponse{}, nil).Do(
653+
func(ctx context.Context, request *workflowservice.RespondActivityTaskCanceledByIdRequest, opts ...grpc.CallOption) {
654654
canceledRequest = request
655655
})
656-
mockService.EXPECT().RespondActivityTaskFailedByID(gomock.Any(), gomock.Any(), gomock.Any()).Return(&workflowservice.RespondActivityTaskFailedByIDResponse{}, nil).Do(
657-
func(ctx context.Context, request *workflowservice.RespondActivityTaskFailedByIDRequest, opts ...grpc.CallOption) {
656+
mockService.EXPECT().RespondActivityTaskFailedById(gomock.Any(), gomock.Any(), gomock.Any()).Return(&workflowservice.RespondActivityTaskFailedByIdResponse{}, nil).Do(
657+
func(ctx context.Context, request *workflowservice.RespondActivityTaskFailedByIdRequest, opts ...grpc.CallOption) {
658658
failedRequest = request
659659
})
660660

@@ -710,10 +710,10 @@ func (s *internalWorkerTestSuite) TestRecordActivityHeartbeat_WithDataConverter(
710710

711711
func (s *internalWorkerTestSuite) TestRecordActivityHeartbeatByID() {
712712
wfClient := NewServiceClient(s.service, nil, ClientOptions{Namespace: "testNamespace"})
713-
var heartbeatRequest *workflowservice.RecordActivityTaskHeartbeatByIDRequest
714-
heartbeatResponse := workflowservice.RecordActivityTaskHeartbeatByIDResponse{CancelRequested: false}
715-
s.service.EXPECT().RecordActivityTaskHeartbeatByID(gomock.Any(), gomock.Any(), gomock.Any()).Return(&heartbeatResponse, nil).
716-
Do(func(ctx context.Context, request *workflowservice.RecordActivityTaskHeartbeatByIDRequest, opts ...grpc.CallOption) {
713+
var heartbeatRequest *workflowservice.RecordActivityTaskHeartbeatByIdRequest
714+
heartbeatResponse := workflowservice.RecordActivityTaskHeartbeatByIdResponse{CancelRequested: false}
715+
s.service.EXPECT().RecordActivityTaskHeartbeatById(gomock.Any(), gomock.Any(), gomock.Any()).Return(&heartbeatResponse, nil).
716+
Do(func(ctx context.Context, request *workflowservice.RecordActivityTaskHeartbeatByIdRequest, opts ...grpc.CallOption) {
717717
heartbeatRequest = request
718718
}).Times(2)
719719

0 commit comments

Comments
 (0)