Skip to content

Commit dd50e0c

Browse files
committed
Clarifying comments
1 parent 9f6bcb6 commit dd50e0c

File tree

3 files changed

+21
-10
lines changed

3 files changed

+21
-10
lines changed

openapi/openapiv2.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8968,7 +8968,7 @@
89688968
},
89698969
"runId": {
89708970
"type": "string",
8971-
"title": "Run Id of the workflow which scheduled this activity"
8971+
"description": "For a workflow activity - the run ID of the workflow which scheduled this activity.\nFor a standalone activity - the run ID of the activity."
89728972
},
89738973
"activityId": {
89748974
"type": "string",
@@ -9027,7 +9027,7 @@
90279027
},
90289028
"runId": {
90299029
"type": "string",
9030-
"title": "Run Id of the workflow which scheduled this activity"
9030+
"description": "For a workflow activity - the run ID of the workflow which scheduled this activity.\nFor a standalone activity - the run ID of the activity."
90319031
},
90329032
"activityId": {
90339033
"type": "string",
@@ -9086,7 +9086,7 @@
90869086
},
90879087
"runId": {
90889088
"type": "string",
9089-
"title": "Run Id of the workflow which scheduled this activity"
9089+
"description": "For a workflow activity - the run ID of the workflow which scheduled this activity.\nFor a standalone activity - the run ID of the activity."
90909090
},
90919091
"activityId": {
90929092
"type": "string",
@@ -14329,7 +14329,7 @@
1432914329
},
1433014330
"activityId": {
1433114331
"type": "string",
14332-
"description": "The autogenerated or user specified identifier of this activity. Can be used to complete the\nactivity via `RespondActivityTaskCompletedById`. May be re-used as long as the last usage\nhas resolved, but unique IDs for every activity invocation is a good idea."
14332+
"description": "The autogenerated or user specified identifier of this activity. Can be used to complete the\nactivity via `RespondActivityTaskCompletedById`. May be re-used as long as the last usage\nhas resolved, but unique IDs for every activity invocation is a good idea.\nNote that only a workflow activity ID may be autogenerated."
1433314333
},
1433414334
"header": {
1433514335
"$ref": "#/definitions/v1Header",

openapi/openapiv3.yaml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10821,6 +10821,7 @@ components:
1082110821
The autogenerated or user specified identifier of this activity. Can be used to complete the
1082210822
activity via `RespondActivityTaskCompletedById`. May be re-used as long as the last usage
1082310823
has resolved, but unique IDs for every activity invocation is a good idea.
10824+
Note that only a workflow activity ID may be autogenerated.
1082410825
header:
1082510826
allOf:
1082610827
- $ref: '#/components/schemas/Header'
@@ -11788,7 +11789,9 @@ components:
1178811789
description: Id of the workflow which scheduled this activity, leave empty to target a standalone activity
1178911790
runId:
1179011791
type: string
11791-
description: Run Id of the workflow which scheduled this activity
11792+
description: |-
11793+
For a workflow activity - the run ID of the workflow which scheduled this activity.
11794+
For a standalone activity - the run ID of the activity.
1179211795
activityId:
1179311796
type: string
1179411797
description: Id of the activity to confirm is cancelled
@@ -11855,7 +11858,9 @@ components:
1185511858
description: Id of the workflow which scheduled this activity, leave empty to target a standalone activity
1185611859
runId:
1185711860
type: string
11858-
description: Run Id of the workflow which scheduled this activity
11861+
description: |-
11862+
For a workflow activity - the run ID of the workflow which scheduled this activity.
11863+
For a standalone activity - the run ID of the activity.
1185911864
activityId:
1186011865
type: string
1186111866
description: Id of the activity to complete
@@ -11918,7 +11923,9 @@ components:
1191811923
description: Id of the workflow which scheduled this activity, leave empty to target a standalone activity
1191911924
runId:
1192011925
type: string
11921-
description: Run Id of the workflow which scheduled this activity
11926+
description: |-
11927+
For a workflow activity - the run ID of the workflow which scheduled this activity.
11928+
For a standalone activity - the run ID of the activity.
1192211929
activityId:
1192311930
type: string
1192411931
description: Id of the activity to fail

temporal/api/workflowservice/v1/request_response.proto

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -461,6 +461,7 @@ message PollActivityTaskQueueResponse {
461461
// The autogenerated or user specified identifier of this activity. Can be used to complete the
462462
// activity via `RespondActivityTaskCompletedById`. May be re-used as long as the last usage
463463
// has resolved, but unique IDs for every activity invocation is a good idea.
464+
// Note that only a workflow activity ID may be autogenerated.
464465
string activity_id = 6;
465466
// Headers specified by the scheduling workflow. Commonly used to propagate contextual info
466467
// from the workflow to its activities. For example, tracing contexts.
@@ -580,7 +581,8 @@ message RespondActivityTaskCompletedByIdRequest {
580581
string namespace = 1;
581582
// Id of the workflow which scheduled this activity, leave empty to target a standalone activity
582583
string workflow_id = 2;
583-
// Run Id of the workflow which scheduled this activity
584+
// For a workflow activity - the run ID of the workflow which scheduled this activity.
585+
// For a standalone activity - the run ID of the activity.
584586
string run_id = 3;
585587
// Id of the activity to complete
586588
string activity_id = 4;
@@ -627,7 +629,8 @@ message RespondActivityTaskFailedByIdRequest {
627629
string namespace = 1;
628630
// Id of the workflow which scheduled this activity, leave empty to target a standalone activity
629631
string workflow_id = 2;
630-
// Run Id of the workflow which scheduled this activity
632+
// For a workflow activity - the run ID of the workflow which scheduled this activity.
633+
// For a standalone activity - the run ID of the activity.
631634
string run_id = 3;
632635
// Id of the activity to fail
633636
string activity_id = 4;
@@ -674,7 +677,8 @@ message RespondActivityTaskCanceledByIdRequest {
674677
string namespace = 1;
675678
// Id of the workflow which scheduled this activity, leave empty to target a standalone activity
676679
string workflow_id = 2;
677-
// Run Id of the workflow which scheduled this activity
680+
// For a workflow activity - the run ID of the workflow which scheduled this activity.
681+
// For a standalone activity - the run ID of the activity.
678682
string run_id = 3;
679683
// Id of the activity to confirm is cancelled
680684
string activity_id = 4;

0 commit comments

Comments
 (0)