Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Failing target manager test case #258

Open
1 task done
lvlcn-t opened this issue Jan 22, 2025 · 0 comments
Open
1 task done

Bug: Failing target manager test case #258

lvlcn-t opened this issue Jan 22, 2025 · 0 comments
Labels
area/target-manager Issues/PRs related to the TargetManager bug Something isn't working

Comments

@lvlcn-t
Copy link
Collaborator

lvlcn-t commented Jan 22, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The target manager tests fail currently on the main branch.

https://github.com/telekom/sparrow/actions/runs/12882515452/job/35914912897

Expected Behavior

The tests should all pass.

Steps To Reproduce

No response

Relevant logs and/or screenshots, environment information, etc.

=== RUN   Test_gitlabTargetManager_Reconcile_Shutdown_Fail_Unregister
{"time":"2025-01-21T08:02:44.25785054Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets.(*manager).Reconcile","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/manager.go","line":109},"msg":"Starting target manager reconciliation"}
{"time":"2025-01-21T08:02:44.298233315Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).FetchFiles","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":62},"msg":"MockFetchFiles called","targets":1,"err":null}
{"time":"2025-01-21T08:02:44.298315598Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).PutFile","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":44},"msg":"MockPutFile called","err":null}
{"time":"2025-01-21T08:02:44.358526583Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).FetchFiles","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":62},"msg":"MockFetchFiles called","targets":1,"err":null}
{"time":"2025-01-21T08:02:44.398330017Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).FetchFiles","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":62},"msg":"MockFetchFiles called","targets":1,"err":null}
{"time":"2025-01-21T08:02:44.398462504Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).PutFile","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":44},"msg":"MockPutFile called","err":null}
{"time":"2025-01-21T08:02:44.40[863](https://github.com/telekom/sparrow/actions/runs/12882515452/job/35914912897#step:4:864)7761Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).PostFile","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":53},"msg":"MockPostFile called","err":null}
{"time":"2025-01-21T08:02:44.408721427Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets.(*manager).register","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/manager.go","line":210},"msg":"Successfully registered"}
{"time":"2025-01-21T08:02:44.459554932Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).FetchFiles","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":62},"msg":"MockFetchFiles called","targets":1,"err":null}
{"time":"2025-01-21T08:02:44.499460043Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).FetchFiles","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":62},"msg":"MockFetchFiles called","targets":1,"err":null}
{"time":"2025-01-21T08:02:44.499545413Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).PutFile","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":44},"msg":"MockPutFile called","err":null}
{"time":"2025-01-21T08:02:44.508791196Z","level":"INFO","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets/remote/test.(*MockClient).DeleteFile","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/remote/test/remotemock.go","line":68},"msg":"MockDeleteFile called","filename":{"AuthorEmail":"test@sparrow","AuthorName":"test","CommitMessage":"Unregistering global target","Content":{"url":"","lastSeen":"0001-01-01T00:00:00Z"},"Name":"test.json"},"err":"gitlab API error"}
{"time":"2025-01-21T08:02:44.508[867](https://github.com/telekom/sparrow/actions/runs/12882515452/job/35914912897#step:4:868)93Z","level":"ERROR","source":{"function":"github.com/telekom/sparrow/pkg/sparrow/targets.(*manager).Shutdown","file":"/home/runner/work/sparrow/sparrow/pkg/sparrow/targets/manager.go","line":167},"msg":"Failed to shutdown gracefully","error":"gitlab API error"}
    manager_test.go:703: Reconcile() should have made calls to the gitlab API
--- FAIL: Test_gitlabTargetManager_Reconcile_Shutdown_Fail_Unregister (0.25s)

Who can address the issue?

Everyone.

Anything else?

No response

@lvlcn-t lvlcn-t added area/target-manager Issues/PRs related to the TargetManager bug Something isn't working labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/target-manager Issues/PRs related to the TargetManager bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant