Save remote ansible playbooks to correct directory

[therazix]

This PR changes the location where remote ansible playbooks are saved. Previously, they were saved in the plan's directory, but now they are saved in the workdir (/var/tmp/tmt/...) to ensure that tmt does not modify the plan directory.

This change also resolves the issue with remote ansible playbooks not functioning correctly when used with imported plans.

Fixes: #3237
Fixes: #3349

Pull Request Checklist

• implement the feature
• write the documentation
• extend the test coverage

[happz]

/packit build

[therazix]

@happz I noticed there is a similar issue #3237 and I tried to fix it in 8855a08. Now, remote playbooks are saved in the prepare directory inside the workdir (/var/tmp/tmt/run-xyz/plans/plan_name/prepare), which gets purged during the finish step. Does this approach make sense, or would it be better to use a different directory so the playbook is preserved beyond the finish step?

[happz]

@happz I noticed there is a similar issue #3237 and I tried to fix it in 8855a08.

Makes sense, it seems to be the same kind of trouble.

Now, remote playbooks are saved in the prepare directory inside the workdir (/var/tmp/tmt/run-xyz/plans/plan_name/prepare), which gets purged during the finish step. Does this approach make sense, or would it be better to use a different directory so the playbook is preserved beyond the finish step?

I'd say workdir is a good option. We can always improve finish to not remove them when pruning its workdir, either by giving them some shared filename prefix (ansible-remote-playbook-foo.yaml?) or putting remote playbooks in a dedicated directory ($workdir/remote-ansible-playbooks?).

[happz]

As soon as self.step.workdir appears for the second time, I'd suggest changing the normalize_* family of functions to return both playbook root and playbook, i.e. -> tuple[Path, AnsibleApplicable], and most of them would return anchor_path but normalize_remote_playbook would return (self.step.workdir, Path(file.name).relative_to(root_path)).

That way, the "this kind of playbook lives in step workdir" knowledge would be owned by the code responsible for processing the raw playbook path, instead of being "shared" by this code and code calling it.

What do you think?

[therazix]

Great idea. Updated in 590b020.