Fix(Pack): Cannot use "external" without "bundle"

techor-dev · Aug 10, 2023 · ab31fa7 · ab31fa7
1 parent 2383e9a
commit ab31fa7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/sync-dev-branches.yml b/.github/workflows/sync-dev-branches.yml
@@ -14,7 +14,7 @@ jobs:
         steps:
             - uses: actions/checkout@v3
             - name: Sync dev branches
-              uses: 1aron/techor@v2.4.6
+              uses: 1aron/techor@v2.5.6
               with:
                   action: "sync-dev-branches"
               env:

diff --git a/packages/pack/src/actions/main.ts b/packages/pack/src/actions/main.ts
@@ -98,7 +98,7 @@ module.exports = async function action(specifiedEntries: string[], options: any
         }
         const eachOutdir = eachOptions.outdir || options.outdir
 
-        /** 
+        /**
          * Keep original directory output and prevent bundling
          * @example $ esbuild entry.js a.js b.js external.j --format=esm --outdir=dist --bundle --external:./a --external:./b
          * @example https://esbuild.github.io/try/#YgAwLjE4LjExAGVudHJ5LmpzIGEuanMgYi5qcyBleHRlcm5hbC5qIC0tZm9ybWF0PWVzbSAtLW91dGRpcj1kaXN0IC0tYnVuZGxlIC0tZXh0ZXJuYWw6Li9hIC0tZXh0ZXJuYWw6Li9iAABlbnRyeS5qcwBleHBvcnQgKiBmcm9tICcuL2EnCmV4cG9ydCAqIGZyb20gJy4vYicKZXhwb3J0ICogZnJvbSAnLi9leHRlcm5hbCcAAGEuanMAZXhwb3J0IGNvbnN0IGEgPSAnYScAAGIuanMAZXhwb3J0IGNvbnN0IGIgPSAnYicAAGV4dGVybmFsLmpzAGV4cG9ydCBjb25zdCBleHRlcm5hbCA9ICdleHRlcm5hbCc
@@ -133,6 +133,11 @@ module.exports = async function action(specifiedEntries: string[], options: any
             delete buildOptions.target
         }
 
+        // Fixed: Cannot use "external" option with "bundle" option
+        if (!buildOptions.bundle) {
+            delete buildOptions.external
+        }
+
         // if (!eachOptions.bundle && eachOptions.format === 'esm') {
         //     buildOptions.plugins.push(createFillModuleExtPlugin(options.esmExt))
         // }