Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to reduce number of dependencies #17

Open
benmccann opened this issue Jun 15, 2023 · 2 comments · May be fixed by #18
Open

Suggestion to reduce number of dependencies #17

benmccann opened this issue Jun 15, 2023 · 2 comments · May be fixed by #18

Comments

@benmccann
Copy link

array.prototype.flat has 50 dependencies.

Node 10 support ended May 19, 2020.

Would you be open to a PR to drop support for Node 6-10 and remove array.prototype.flat as a dependency?
@benmccann
Copy link
Author

Alternatively, I could swap the implementation to array-flat-polyfill, which has no dependencies. Or I could re-implement flat in this project, which would probably be less than a dozen lines of code. Let me know if you have a preference and I would be happy to send a PR

@nwalters512
Copy link

I came to this repo to suggest the same thing! I'd +1 dropping Node 10, which has long since reached EOL.

@benmccann benmccann linked a pull request Jun 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: drop support for Node 6-10 and remove 50 dependencies benmccann/smartwrap
2 participants
@benmccann @nwalters512